From: Johan Jonker <jbx6244@gmail.com>
To: Jianqun Xu <jay.xu@rock-chips.com>,
linus.walleij@linaro.org, heiko@sntech.de
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] pinctrl: rockchip: add support for rk3568
Date: Tue, 23 Feb 2021 11:08:07 +0100 [thread overview]
Message-ID: <9a725c5c-b5c8-0ac9-738e-ad89f1188345@gmail.com> (raw)
In-Reply-To: <20210223072419.123308-1-jay.xu@rock-chips.com>
Hi Jianqun,
Before a new compatible string is used in your code it must be added to
the documentation with a separate patch to rockchip,pinctrl.txt .
To get a ack-by you must include:
robh+dt@kernel.org
devicetree@vger.kernel.org
Your patch should show up here after filtering:
https://patchwork.ozlabs.org/project/devicetree-bindings/list/
./scripts/checkpatch.pl --strict
0001-pinctrl-rockchip-add-support-for-rk3568.patch
WARNING: DT compatible string "rockchip,rk3568-pinctrl" appears
un-documented -- check ./Documentation/devicetree/bindings/
#424: FILE: drivers/pinctrl/pinctrl-rockchip.c:4547:
+ { .compatible = "rockchip,rk3568-pinctrl",
On 2/23/21 8:24 AM, Jianqun Xu wrote:
> RK3568 SoCs have 5 gpio controllers, each gpio has 32 pins. GPIO supports
> set iomux, pull, drive strength, schmitt and slew rate.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
[..]
> static const struct of_device_id rockchip_pinctrl_dt_match[] = {
> { .compatible = "rockchip,px30-pinctrl",
> .data = &px30_pin_ctrl },
> @@ -4239,6 +4544,8 @@ static const struct of_device_id rockchip_pinctrl_dt_match[] = {
> .data = &rk3368_pin_ctrl },
> { .compatible = "rockchip,rk3399-pinctrl",
> .data = &rk3399_pin_ctrl },
> + { .compatible = "rockchip,rk3568-pinctrl",
> + .data = &rk3568_pin_ctrl },
> {},
> };
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-02-23 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 7:24 [PATCH] pinctrl: rockchip: add support for rk3568 Jianqun Xu
2021-02-23 10:08 ` Johan Jonker [this message]
2021-02-23 10:11 ` Heiko Stübner
2021-02-24 11:39 ` [PATCH v2] " Jianqun Xu
2021-03-04 0:58 ` [PATCH v3] " Jianqun Xu
2021-03-04 1:33 ` [PATCH v3 RESEND] " Jianqun Xu
2021-03-05 1:24 ` Kever Yang
2021-03-19 8:11 ` [PATCH v3] " Jianqun Xu
2021-03-19 8:14 ` [PATCH v4] " Jianqun Xu
2021-03-19 11:28 ` jay.xu
2021-04-08 13:40 ` Linus Walleij
2021-04-09 4:17 ` Ezequiel Garcia
2021-04-09 12:37 ` Linus Walleij
2021-04-10 18:30 ` Peter Geis
2021-04-10 21:10 ` Heiko Stübner
2021-04-11 0:40 ` Linus Walleij
2021-04-11 3:40 ` Peter Geis
2021-04-11 7:55 ` Heiko Stübner
2021-04-14 7:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a725c5c-b5c8-0ac9-738e-ad89f1188345@gmail.com \
--to=jbx6244@gmail.com \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).