From: Arnd Bergmann <arnd@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: DTML <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Johan Jonker <jbx6244@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] ARM: dts: rockchip: assign a fixed index to mmc devices on rv1108 boards
Date: Wed, 10 Feb 2021 14:53:02 +0100 [thread overview]
Message-ID: <CAK8P3a0ALgbhTVJ7t3XRXALs9vBM=XBvkGhNKXxB+QTepo-3AQ@mail.gmail.com> (raw)
In-Reply-To: <46108228.fMDQidcC6G@diego>
On Wed, Feb 10, 2021 at 11:49 AM Heiko Stübner <heiko@sntech.de> wrote:
> Am Mittwoch, 10. Februar 2021, 11:34:41 CET schrieb Arnd Bergmann:
> > On Wed, Feb 10, 2021 at 12:50 AM Heiko Stübner <heiko@sntech.de> wrote:
> > > Am Dienstag, 9. Februar 2021, 23:25:40 CET schrieb Arnd Bergmann:
> > Each board should have its own aliases node that describes
> > exactly which of the devices are wired up on that board, and
> > in which order. If there are connectors on the board that
> > are labeled in some form, then the aliases are meant to
> > match what is written on the board or in its documentation.
>
> Then we're at least in the clear for i2c, serial and the rest ... as these
> are numbered in the soc documentation, and all boards I've seen so
> far use these number also to identify these in schematics.
Ok, that is helpful. It would still be good to ensure that only aliases
exist for nodes that are actually enabled.
> So an i2c2 is always i2c2 even if i2c1 is not populated.
>
> And of course doing
> i2c0 = &i2c2
> would definitly confuse people to no end.
I think that's just an unfortunate choice of the labels here,
it's sometimes easier to just refer to the node by the full
path instead of the label.
Arnd
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-02-10 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 15:52 [PATCH 1/5] ARM: dts: rockchip: assign a fixed index to mmc devices on rk322x boards Johan Jonker
2021-01-18 15:52 ` [PATCH 2/5] ARM: dts: rockchip: assign a fixed index to mmc devices on rv1108 boards Johan Jonker
2021-02-09 22:25 ` Arnd Bergmann
2021-02-09 23:50 ` Heiko Stübner
2021-02-10 10:34 ` Arnd Bergmann
2021-02-10 10:49 ` Heiko Stübner
2021-02-10 13:53 ` Arnd Bergmann [this message]
2021-01-18 15:52 ` [PATCH 3/5] arm64: dts: rockchip: assign a fixed index to mmc devices on px30 boards Johan Jonker
2021-01-18 15:52 ` [PATCH 4/5] arm64: dts: rockchip: assign a fixed index to mmc devices on rk3308 boards Johan Jonker
2021-01-18 15:52 ` [PATCH 5/5] arm64: dts: rockchip: assign a fixed index to mmc devices on rk3368 boards Johan Jonker
2021-01-25 23:56 ` (subset) [PATCH 1/5] ARM: dts: rockchip: assign a fixed index to mmc devices on rk322x boards Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0ALgbhTVJ7t3XRXALs9vBM=XBvkGhNKXxB+QTepo-3AQ@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).