From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH 10/11] rockpro-rk3399: Enable SPI Flash Date: Wed, 8 Jan 2020 18:29:07 +0530 Message-ID: References: <20191221075440.6944-1-jagan@amarulasolutions.com> <20191221075440.6944-11-jagan@amarulasolutions.com> <20191230125134.189ba860e7fc99b4ad2f1def@bidouilliste.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20191230125134.189ba860e7fc99b4ad2f1def@bidouilliste.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Emmanuel Vadot Cc: "open list:ARM/Rockchip SoC..." , U-Boot-Denx , linux-amarula List-Id: linux-rockchip.vger.kernel.org On Mon, Dec 30, 2019 at 5:21 PM Emmanuel Vadot wrote: > > > Hi Jagan, > > On Sat, 21 Dec 2019 13:24:39 +0530 > Jagan Teki wrote: > > > Enable winbond SPI flash for ROC-PC-RK3399 board. > > s/ROC-PC-RK3399/RockPro64/ > > > > > Signed-off-by: Jagan Teki > > --- > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 4 ++++ > > configs/rockpro64-rk3399_defconfig | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > > index 4648513ea9..deaa3efd39 100644 > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi > > @@ -6,6 +6,10 @@ > > #include "rk3399-u-boot.dtsi" > > #include "rk3399-sdram-lpddr4-100.dtsi" > > / { > > + aliases { > > + spi0 = &spi1; > > That looks weird ... what's the point of this alias exactly ? spi uclass would require alias number to bind the driver, no way to escape as of now.