From: Lee Jones <lee@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv3 02/14] mfd: rk808: use dev_err_probe
Date: Wed, 28 Sep 2022 14:51:51 +0100 [thread overview]
Message-ID: <YzRRd/4Wdr5Comu1@google.com> (raw)
In-Reply-To: <20220909175522.179175-3-sebastian.reichel@collabora.com>
On Fri, 09 Sep 2022, Sebastian Reichel wrote:
> Use dev_err_probe instead of dev_err in probe function,
> which simplifies code a little bit and prints the error
> code.
>
> Also drop possibly incorrect printing of chip id registers
> while touching the error message.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/mfd/rk808.c | 48 +++++++++++++++------------------------------
> 1 file changed, 16 insertions(+), 32 deletions(-)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-28 13:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 17:55 [PATCHv3 00/14] Introduce RK806 Support Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 01/14] mfd: rk808: convert to device managed resources Sebastian Reichel
2022-09-28 13:38 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 02/14] mfd: rk808: use dev_err_probe Sebastian Reichel
2022-09-28 13:51 ` Lee Jones [this message]
2022-09-09 17:55 ` [PATCHv3 03/14] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 04/14] regulator: rk808: " Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 05/14] rtc: " Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 06/14] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel
2022-09-28 14:00 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 07/14] mfd: rk808: split into core and i2c Sebastian Reichel
2022-09-28 14:13 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 08/14] dt-bindings: mfd: add rk806 binding Sebastian Reichel
2022-09-10 8:03 ` Krzysztof Kozlowski
2022-09-09 17:55 ` [PATCHv3 09/14] mfd: rk8xx: add rk806 support Sebastian Reichel
2022-09-28 14:35 ` Lee Jones
2022-09-09 17:55 ` [PATCHv3 10/14] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 11/14] regulator: rk808: Use dev_err_probe Sebastian Reichel
2022-09-09 17:55 ` [PATCHv3 12/14] regulator: expose regmap_find_closest_bigger Sebastian Reichel
2022-09-10 17:17 ` Matti Vaittinen
2022-09-19 14:15 ` Sebastian Reichel
2022-09-28 17:37 ` Mark Brown
2022-09-09 17:55 ` [PATCHv3 13/14] regulator: rk808: add rk806 support Sebastian Reichel
2022-09-10 17:03 ` Matti Vaittinen
2022-09-09 17:55 ` [PATCHv3 14/14] ASoC: rk817: Remove 'select REGMAP_I2C' Sebastian Reichel
2022-11-28 19:05 ` (subset) [PATCHv3 00/14] Introduce RK806 Support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRRd/4Wdr5Comu1@google.com \
--to=lee@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).