From: Michael Riesch <michael.riesch@wolfvision.net>
To: Mark Brown <broonie@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
kernel@pengutronix.de
Subject: Re: [PATCH 3/4] soc: rockchip: power-domain: Add regulator support
Date: Wed, 23 Feb 2022 09:51:50 +0100 [thread overview]
Message-ID: <a6145f16-c75d-2045-0a1f-9cf5fcb48464@wolfvision.net> (raw)
In-Reply-To: <YcMq4vF7yKn7iu5U@sirena.org.uk>
Hi Mark,
Sorry for the long pause!
On 12/22/21 14:40, Mark Brown wrote:
> On Wed, Dec 22, 2021 at 02:29:23PM +0100, Michael Riesch wrote:
>> On 12/22/21 2:25 PM, Mark Brown wrote:
>
>>> In that case I would tend to assume that unless otherwise stated it's
>>> safer to keep the supply enabled when everything else is enabled. It's
>>> the default thing and so is more likely to be what was designed for and
>>> less likely to result in nasty surprises.
>
>> Based on my experience with the RK3568 EVB1 the vdd_gpu supply turns
>> after startup if it is unused and the SoC works fine. Let's take the
>> energy efficient route here :-)
>
> One of the issues is that it may not actually be energy efficient if it
> ends up leaking current through the SoC from the other supplies (and
> long term that leakage probably won't do any good for hardware). A very
> lightly loaded regulator can be the better option.
OK, I see. So in summary we don't know the behavior of the SoC and
should go for the safe route (set the GPU regulator to always on)? I'll
submit a patch for the RK3568 EVB1 -- the other boards enable this
regulator always as well.
Best regards,
Michael
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-02-23 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 13:09 [PATCH 0/4] soc: rockchip: power-domain: Add regulator support Sascha Hauer
2021-12-17 13:09 ` [PATCH 1/4] soc: rockchip: power-domain: register device for each domain Sascha Hauer
2021-12-17 13:09 ` [PATCH 2/4] soc: rockchip: power-domain: Use devm_clk_bulk_get_all() Sascha Hauer
2021-12-17 13:09 ` [PATCH 3/4] soc: rockchip: power-domain: Add regulator support Sascha Hauer
2021-12-20 9:44 ` Sascha Hauer
2021-12-20 10:46 ` Robin Murphy
2021-12-20 12:56 ` Mark Brown
2021-12-20 12:53 ` Mark Brown
2021-12-22 10:40 ` Sascha Hauer
2021-12-22 12:54 ` Robin Murphy
2021-12-22 13:00 ` Mark Brown
2021-12-22 13:19 ` Robin Murphy
2021-12-22 13:25 ` Mark Brown
2021-12-22 13:29 ` Michael Riesch
2021-12-22 13:37 ` Michael Riesch
2021-12-22 13:40 ` Mark Brown
2022-02-23 8:51 ` Michael Riesch [this message]
2021-12-17 13:09 ` [PATCH 4/4] dt-bindings: power: rockchip: Add power-supply to domain nodes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6145f16-c75d-2045-0a1f-9cf5fcb48464@wolfvision.net \
--to=michael.riesch@wolfvision.net \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).