From: Dragan Simic <dsimic@manjaro.org>
To: Alexey Charkov <alchark@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: enable temperature driven fan control on Rock 5B
Date: Sat, 27 Jan 2024 21:27:24 +0100 [thread overview]
Message-ID: <b5b1900a6e309890f449ec91594b8d6c@manjaro.org> (raw)
In-Reply-To: <df062818d21f3318c033859d0e95efc7@manjaro.org>
Hello Alexey,
On 2024-01-26 00:13, Dragan Simic wrote:
> On 2024-01-24 21:30, Alexey Charkov wrote:
>> This enables thermal monitoring on Radxa Rock 5B and links the PWM
>> fan as an active cooling device managed automatically by the thermal
>> subsystem, with a target SoC temperature of 55C
>>
>> Signed-off-by: Alexey Charkov <alchark@gmail.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 25
>> ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> index 9b7bf6cec8bd..c4c94e0b6163 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> @@ -52,7 +52,7 @@ led_rgb_b {
>>
>> fan: pwm-fan {
>> compatible = "pwm-fan";
>> - cooling-levels = <0 95 145 195 255>;
>> + cooling-levels = <0 120 150 180 210 240 255>;
>> fan-supply = <&vcc5v0_sys>;
>> pwms = <&pwm1 0 50000 0>;
>> #cooling-cells = <2>;
>> @@ -180,6 +180,25 @@ &cpu_l3 {
>> cpu-supply = <&vdd_cpu_lit_s0>;
>> };
>>
>> +&package_thermal {
>> + polling-delay = <1000>;
>> +
>> + trips {
>> + package_fan: package-fan {
>> + temperature = <55000>;
>> + hysteresis = <2000>;
>> + type = "active";
>> + };
>> + };
>> +
>> + cooling-maps {
>> + map-fan {
>> + trip = <&package_fan>;
>> + cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>> + };
>> + };
>> +};
>
> It should be better to have two new trips and two new cooling maps
> defined, instead of having just one trip/map pair, like this:
>
> &package_thermal {
> polling-delay = <1000>;
>
> trips {
> package_warm: package-warm {
> temperature = <55000>;
> hysteresis = <2000>;
> type = "active";
> };
>
> package_hot: package-hot {
> temperature = <65000>;
> hysteresis = <2000>;
> type = "active";
> };
> };
>
> cooling-maps {
> mapX {
> trip = <&package_warm>;
> cooling-device = <&fan THERMAL_NO_LIMIT 1>;
> };
>
> mapY {
> trip = <&package_hot>;
> cooling-device = <&fan 2 THERMAL_NO_LIMIT>;
> };
> };
> };
>
> The idea behind this approach is to keep the fan spinning at the lowest
> available speed until the package temperature reaches the second trip's
> temperature level, at which point the fan starts ramping up. An
> approach
> like this is already employed by the Pine64 RockPro64 SBC.
>
> This way, we'll be doing our best to keep the fan noise down; of
> course,
> it will depend on the particular heatsink and fan combo how long the
> fan
> can be kept at the lowest speed, but we should aim at supporting as
> many
> different cooling setups as possible, and as well as possible, out of
> the
> box and with no additional tweaking required.
>
> Please notice "mapX" and "mapY" as the names of the additional cooling
> maps,
> where X and Y are simply the next lowest available indices, which is
> pretty
> much the usual way to name the additional cooling maps.
Just checking, have you seen this? Quite a few messages were exchanged
on the same day, so just wanted to make sure you didn't miss this one.
>> &i2c0 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&i2c0m2_xfer>;
>> @@ -738,6 +757,10 @@ regulator-state-mem {
>> };
>> };
>>
>> +&tsadc {
>> + status = "okay";
>> +};
>> +
>> &uart2 {
>> pinctrl-0 = <&uart2m0_xfer>;
>> status = "okay";
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-01-27 20:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 20:30 [PATCH 0/4] RK3588 and Rock 5B dts additions: thermal, OPP, rfkill and fan Alexey Charkov
2024-01-24 20:30 ` [PATCH 1/4] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b Alexey Charkov
2024-01-24 20:30 ` [PATCH 2/4] arm64: dts: rockchip: enable built-in thermal monitoring on rk3588 Alexey Charkov
2024-01-24 21:56 ` Daniel Lezcano
2024-01-25 8:26 ` Alexey Charkov
2024-01-25 10:02 ` Daniel Lezcano
2024-01-25 14:46 ` Alexey Charkov
2024-01-25 22:19 ` Dragan Simic
2024-01-25 13:34 ` Diederik de Haas
2024-01-24 20:30 ` [PATCH 3/4] arm64: dts: rockchip: enable temperature driven fan control on Rock 5B Alexey Charkov
2024-01-24 21:59 ` Daniel Lezcano
2024-01-25 23:13 ` Dragan Simic
2024-01-27 20:27 ` Dragan Simic [this message]
2024-01-28 20:08 ` Alexey Charkov
2024-01-29 0:46 ` Dragan Simic
2024-01-24 20:30 ` [PATCH 4/4] arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 Alexey Charkov
2024-01-25 9:30 ` Daniel Lezcano
2024-01-25 10:17 ` Alexey Charkov
2024-01-26 6:32 ` Dragan Simic
2024-01-26 6:44 ` Alexey Charkov
2024-01-26 7:04 ` Dragan Simic
2024-01-26 7:30 ` Alexey Charkov
2024-01-26 7:49 ` Dragan Simic
2024-01-26 12:56 ` Daniel Lezcano
2024-01-26 13:44 ` Alexey Charkov
2024-01-26 20:33 ` Dragan Simic
2024-01-27 19:41 ` Alexey Charkov
2024-01-28 3:35 ` Dragan Simic
2024-01-28 19:14 ` Alexey Charkov
2024-01-29 0:09 ` Dragan Simic
2024-01-29 7:39 ` Dragan Simic
2024-01-28 15:06 ` Daniel Lezcano
2024-01-28 19:32 ` Alexey Charkov
2024-01-26 20:04 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b1900a6e309890f449ec91594b8d6c@manjaro.org \
--to=dsimic@manjaro.org \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).