From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Doug Anderson <dianders@chromium.org>
Cc: "Hunter, Adrian" <adrian.hunter@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Double Lo <double.lo@cypress.com>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Naveen Gupta <naveen.gupta@cypress.com>,
Madhan Mohan R <madhanmohan.r@cypress.com>,
"mka@chromium.org" <mka@chromium.org>,
Wright Feng <wright.feng@cypress.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"brcm80211-dev-list@cypress.com" <brcm80211-dev-list@cypress.com>,
Franky Lin <franky.lin@broadcom.com>,
linux-k
Subject: Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail
Date: Wed, 12 Jun 2019 13:11:46 +0200 [thread overview]
Message-ID: <c7c6d3f4-ebb1-8964-0616-973fae1ab47d@broadcom.com> (raw)
In-Reply-To: <CAPDyKFo=QMRTkNYUVSE2AqiZgytkTVRXF0Mvznn6trVT4-cR=Q@mail.gmail.com>
On 6/12/2019 12:10 PM, Ulf Hansson wrote:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:
>> mmc_set_data_timeout(md, func->card);
>> mmc_wait_for_req(func->card->host, mr);
> These are not okay, none of these things calls should really be done
> from an SDIO func driver.
>
> It tells me that the func driver is a doing workaround for something
> that should be managed in a common way.
We are using some low-level functions passing chain of skbuff to the
device using CMD53 with scatterlist. If I recall correctly Marvell made
an attempt to have a similar function for it in the mmc stack. Not sure
if that ever made it in. If so I can rework our driver using that API.
If not, I can make a new attempt.
Regards,
Arend
next prev parent reply other threads:[~2019-06-12 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 22:37 [PATCH v3 0/5] brcmfmac: sdio: Deal better w/ transmission errors related to idle Douglas Anderson
2019-06-07 22:37 ` [PATCH v3 1/5] Revert "brcmfmac: disable command decode in sdio_aos" Douglas Anderson
[not found] ` <20190607223716.119277-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-06-07 22:37 ` [PATCH v3 2/5] mmc: core: API for temporarily disabling auto-retuning due to errors Douglas Anderson
2019-06-12 13:25 ` Ulf Hansson
2019-06-07 22:37 ` [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail Douglas Anderson
2019-06-10 8:56 ` Hunter, Adrian
2019-06-10 16:50 ` Doug Anderson
2019-06-11 7:17 ` Adrian Hunter
2019-06-12 10:10 ` Ulf Hansson
2019-06-12 11:11 ` Arend Van Spriel [this message]
2019-06-12 11:48 ` Ulf Hansson
[not found] ` <CAPDyKFpM0+FfvoMo8Z_hxM9rzSjeQZHCsA2SPa8WP+SRDhhsPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-12 13:58 ` Arend Van Spriel
[not found] ` <16b4bfb39e0.2764.9b12b7fc0a3841636cfb5e919b41b954-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2019-06-13 9:48 ` Ulf Hansson
2019-06-07 22:37 ` [PATCH v3 4/5] mmc: core: Export mmc_retune_hold_now() mmc_retune_release() Douglas Anderson
2019-06-07 22:37 ` [PATCH v3 5/5] brcmfmac: sdio: Don't tune while the card is off Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c6d3f4-ebb1-8964-0616-973fae1ab47d@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=adrian.hunter@intel.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=briannorris@chromium.org \
--cc=chi-hsien.lin@cypress.com \
--cc=dianders@chromium.org \
--cc=double.lo@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhanmohan.r@cypress.com \
--cc=mka@chromium.org \
--cc=naveen.gupta@cypress.com \
--cc=netdev@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).