From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE4A8C2D0A8 for ; Mon, 28 Sep 2020 15:29:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38F9421548 for ; Mon, 28 Sep 2020 15:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FjJFCoT8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38F9421548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nYhEfRyIP8qGNxZI9ywPNc9rZIh9Gl5ElNLeslkR2S4=; b=FjJFCoT8AsJyI/EGdOXAMraQR 6+8N08ma25F0Couqd+nf9AjbmLq9+Aw20BCFgqcaDN8VNhz9cKXYgMkTYkfp+HCxJgJVKcnnJZIqv jT7G31IWkb2IlhLz1fxMCld7Xgj4+xAUMOeKjxiKaKUzilNTj9u0H/ViWtmcUvvbYLflCUDKd2k7A d0uhYM8JDIj1MVdkpHO/Tj5aokZ6mNje6j32g9gFnwAeiWErGlbw8bJKHDckAWs6p3Lc5C7dG85dr WG09gS3XSRcLp1rqVxp+W+glrt0KzfBIy1GedQhsNyBrfJk6pJwfbGTtj3qBdmZH5rJZTnEf0FuK2 Oq5OnaEcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMv5g-0003az-KX; Mon, 28 Sep 2020 15:29:24 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMv5a-0003XS-FW for linux-rockchip@lists.infradead.org; Mon, 28 Sep 2020 15:29:22 +0000 Received: from [IPv6:2003:c7:cf13:ec00:c5de:8baa:d62d:6718] (p200300c7cf13ec00c5de8baad62d6718.dip0.t-ipconnect.de [IPv6:2003:c7:cf13:ec00:c5de:8baa:d62d:6718]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8831F299448; Mon, 28 Sep 2020 16:29:15 +0100 (BST) Subject: Re: [PATCH v3 12/12] media: staging: rkisp1: cap: protect access to buf with the spin lock To: Mauro Carvalho Chehab References: <20200922113402.12442-1-dafna.hirschfeld@collabora.com> <20200922113402.12442-13-dafna.hirschfeld@collabora.com> <20200927114326.7446d970@coco.lan> <672c5ca3-a5d1-a1dc-5cc8-3a802208310e@collabora.com> <20200927130528.374342ef@coco.lan> From: Dafna Hirschfeld Message-ID: Date: Mon, 28 Sep 2020 17:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200927130528.374342ef@coco.lan> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_112918_707005_DE8291F6 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com, linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am 27.09.20 um 13:05 schrieb Mauro Carvalho Chehab: > Em Sun, 27 Sep 2020 11:54:10 +0200 > Dafna Hirschfeld escreveu: > >> Am 27.09.20 um 11:43 schrieb Mauro Carvalho Chehab: >>> Em Tue, 22 Sep 2020 13:34:02 +0200 >>> Dafna Hirschfeld escreveu: >>> >>>> The function 'rkisp1_stream_start' calls 'rkisp1_set_next_buf' >>>> which access the buffers, so the call should be protected by >>>> taking the cap->buf.lock. >>>> After this patch, all locks are reviewed and commented so remove >>>> the TODO item "review and comment every lock" >>>> >>>> Signed-off-by: Dafna Hirschfeld >>>> --- >>>> drivers/staging/media/rkisp1/TODO | 1 - >>>> drivers/staging/media/rkisp1/rkisp1-capture.c | 2 ++ >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/staging/media/rkisp1/TODO b/drivers/staging/media/rkisp1/TODO >>>> index f0c90d1c86a8..9662e9b51c7f 100644 >>>> --- a/drivers/staging/media/rkisp1/TODO >>>> +++ b/drivers/staging/media/rkisp1/TODO >>>> @@ -1,6 +1,5 @@ >>>> * Fix pad format size for statistics and parameters entities. >>>> * Fix checkpatch errors. >>>> -* Review and comment every lock >>>> * Handle quantization >>>> * streaming paths (mainpath and selfpath) check if the other path is streaming >>>> in several places of the code, review this, specially that it doesn't seem it >>> >>> >>> FYI, >>> >>> There was a trivial context conflict here. Basically, the upstream >>> version has this: >>> >>> >>> * Add uapi docs. Remember to add documentation of how quantization is handled. >>> >>> I solved the conflict, but as some patches for rkisp1 got merged >>> on a different pull request, and there were some uapi docs at the >>> other PR, maybe this would need to be revisited. >> >> I added the "Configuring Quantization" documentation in Documentation/admin-guide/media/rkisp1.rst >> so the TODO item >> "* Add uapi docs. Remember to add documentation of how quantization is handled." >> can be removed. > > Ok. Please send a followup patch with a "fixes: " tag mentioned the > commit that added it. sent just now, Thanks, Dafna > > Thanks, > Mauro > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip