linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, zyw@rock-chips.com,
	sebastian.reichel@collabora.com, andyshrk@163.com,
	jagan@amarulasolutions.com, perex@perex.cz, tiwai@suse.com,
	lgirdwood@gmail.com, heiko@sntech.de, conor+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/6] ASoC: es8328: Enabling support for 12Mhz sysclk
Date: Wed, 24 May 2023 12:57:02 +0100	[thread overview]
Message-ID: <f5b780ac-e079-4c24-9dfc-05aee52deb9c@sirena.org.uk> (raw)
In-Reply-To: <20230523213825.120077-2-macroalpha82@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 691 bytes --]

On Tue, May 23, 2023 at 04:38:20PM -0500, Chris Morgan wrote:

> +static unsigned int ratios_12000[] = {
> +	8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000,
> +	48000, 88235, 96000,
> +};
> +
> +static struct snd_pcm_hw_constraint_list constraints_12000 = {
> +	.count = ARRAY_SIZE(ratios_12000),
> +	.list = ratios_12000,
> +};

...

> +	case 12000000:
> +		es8328->sysclk_constraints = &constraints_12000;
> +		es8328->mclk_ratios = ratios_12000;

The other constraints have separate rates and ratios, with wildly
different values between the two - the ratio (I'm guessing a clock
divider) being written to a 5 bit field which obviously can't contain
the actual sample rate.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2023-05-24 11:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 21:38 [PATCH 0/6] Add Support for RK3588s Indiedroid Nova Chris Morgan
2023-05-23 21:38 ` [PATCH 1/6] ASoC: es8328: Enabling support for 12Mhz sysclk Chris Morgan
2023-05-23 21:51   ` Mark Brown
2023-05-24 11:57   ` Mark Brown [this message]
2023-05-24 16:12     ` Chris Morgan
2023-05-24 16:44       ` Mark Brown
2023-05-23 21:38 ` [PATCH 2/6] arm64: dts: rockchip: add default pinctrl for rk3588 emmc Chris Morgan
2023-05-23 21:38 ` [PATCH 3/6] arm64: dts: rockchip: Add sdio node to rk3588 Chris Morgan
2023-05-23 21:38 ` [PATCH 4/6] dt-bindings: vendor-prefixes: add Indiedroid Chris Morgan
2023-05-24 20:30   ` Conor Dooley
2023-05-25 13:57     ` Chris Morgan
2023-05-23 21:38 ` [PATCH 5/6] dt-bindings: arm: rockchip: Add Indiedroid Nova Chris Morgan
2023-05-24 20:27   ` Conor Dooley
2023-05-23 21:38 ` [PATCH 6/6] arm64: dts: rockchip: Add Indiedroid Nova board Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5b780ac-e079-4c24-9dfc-05aee52deb9c@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andyshrk@163.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tiwai@suse.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).