Linux-rt-users archive on
 help / color / Atom feed
From: Masami Hiramatsu <>
To: Arnaldo Carvalho de Melo <>
Cc: Masami Hiramatsu <>,
	bhargavb <>,, Paul Clarke <>,
	Ravi Bangoria <>,
	Thomas Richter <>,,
Subject: [PATCH v3 2/5] perf-probe: Cut off the version suffix from event name
Date: Sat,  9 Dec 2017 01:27:15 +0900
Message-ID: <151275043529.24652.13913613297362711909.stgit@devbox> (raw)
In-Reply-To: <151275037752.24652.5169845651138876257.stgit@devbox>

Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from
automatic generated event name. This fixes wildcard event
adding like below case;

  # perf probe -x /lib64/ malloc*
  Internal error: "malloc_get_state@GLIBC_2" is wrong event name.
    Error: Failed to add events.

This failure was caused by a versioned suffix symbol.
With this fix, perf probe automatically cuts the
suffix after @ as below.

  # ./perf probe -x /lib64/ malloc*
  Added new events:
    probe_libc:malloc_printerr (on malloc* in /usr/lib64/
    probe_libc:malloc_consolidate (on malloc* in /usr/lib64/
    probe_libc:malloc_check (on malloc* in /usr/lib64/
    probe_libc:malloc_hook_ini (on malloc* in /usr/lib64/
    probe_libc:malloc    (on malloc* in /usr/lib64/
    probe_libc:malloc_trim (on malloc* in /usr/lib64/
    probe_libc:malloc_usable_size (on malloc* in /usr/lib64/
    probe_libc:malloc_stats (on malloc* in /usr/lib64/
    probe_libc:malloc_info (on malloc* in /usr/lib64/
    probe_libc:mallochook (on malloc* in /usr/lib64/
    probe_libc:malloc_get_state (on malloc* in /usr/lib64/
    probe_libc:malloc_set_state (on malloc* in /usr/lib64/

  You can now use it in all perf tools, such as:

	  perf record -e probe_libc:malloc_set_state -aR sleep 1


Signed-off-by: Masami Hiramatsu <>
Reported-by: Arnaldo Carvalho de Melo <>
Reported-by: bhargavb <>
Acked-by: Ravi Bangoria <>
 tools/perf/util/probe-event.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 262d5da86623..7e582547ac07 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2584,8 +2584,8 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
 	if (!nbase)
 		return -ENOMEM;
-	/* Cut off the dot suffixes (e.g. .const, .isra)*/
-	p = strchr(nbase, '.');
+	/* Cut off the dot suffixes (e.g. .const, .isra) and version suffixes */
+	p = strpbrk(nbase, ".@");
 	if (p && p != nbase)
 		*p = '\0';

  parent reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 16:26 [PATCH v3 0/5] perf-probe: Improve probing on versioned symbols Masami Hiramatsu
2017-12-08 16:26 ` [PATCH v3 1/5] perf-probe: Add warning message if there is unexpected event name Masami Hiramatsu
2017-12-08 16:27 ` Masami Hiramatsu [this message]
2017-12-08 16:27 ` [PATCH v3 3/5] perf-probe: Add __return suffix for return events Masami Hiramatsu
2017-12-08 16:28 ` [PATCH v3 4/5] perf-probe: Find versioned symbols from map Masami Hiramatsu
2017-12-08 16:28 ` [PATCH v3 5/5] perf-probe: Support escaped character in parser Masami Hiramatsu
2017-12-11 20:03   ` Arnaldo Carvalho de Melo
2017-12-12 14:46     ` Masami Hiramatsu
2017-12-12 15:01       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151275043529.24652.13913613297362711909.stgit@devbox \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-rt-users archive on

Archives are clonable:
	git clone --mirror linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ \
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone