From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D008C33CB7 for ; Fri, 31 Jan 2020 23:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47E992071A for ; Fri, 31 Jan 2020 23:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580511640; bh=5BQec15fI5BnSDKDMUTsd+XF8G5rUgn4XWkFuvTm3z8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=nQD8jdz2+x12QIiReTBMIFmq8mMahfmUvbuE2l8c/E++vKxnfyd9MI9xHTYbTQG6r Z1msUbA/Qr4ySL43EKUKUg2J0CxkZ7YJeNfKyCHdTSz/oBVIcCVcFLJ3LkFPYJKzzT FXi9VfTX5MqbzMwgir0yirXfeJS4jST2aJPwEavw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgAaXAh (ORCPT ); Fri, 31 Jan 2020 18:00:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:45048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbgAaXAf (ORCPT ); Fri, 31 Jan 2020 18:00:35 -0500 Received: from tzanussi-mobl (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F93820707; Fri, 31 Jan 2020 23:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580511634; bh=5BQec15fI5BnSDKDMUTsd+XF8G5rUgn4XWkFuvTm3z8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=1/tgV1D8Q0ktKONxi+pLnRRpasxvJ0CF1rXBAmza3iKVCYtiQzWpk7dG8pRoQd3ts 1QEQYDFHKvOT+r+QmIFCom6z3q9DID4l1x9lOduCCdDGeUHfHGZazvPSkq5/AGMYI6 bzoj1ix7DgQTsJrMaHS3eFwQwRhw+9gUgLumAS7I= Message-ID: <1580511632.5607.3.camel@kernel.org> Subject: Re: [PATCH 1/4] tracing: Consolidate some synth_event_trace code From: Tom Zanussi To: Steven Rostedt Cc: artem.bityutskiy@linux.intel.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Fri, 31 Jan 2020 17:00:32 -0600 In-Reply-To: <20200131174344.5606d154@gandalf.local.home> References: <20200131174344.5606d154@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Fri, 2020-01-31 at 17:43 -0500, Steven Rostedt wrote: > On Fri, 31 Jan 2020 15:55:31 -0600 > Tom Zanussi wrote: > > > +++ b/kernel/trace/trace_events_hist.c > > @@ -2053,24 +2053,72 @@ int synth_event_trace_start(struct > > trace_event_file *file, > > } > > EXPORT_SYMBOL_GPL(synth_event_trace_start); > > > > -static int save_synth_val(struct synth_field *field, u64 val, > > +int __synth_event_add_val(const char *field_name, u64 val, > > Hmm, shouldn't __synth_event_add_val() still be static? > > -- Steve > > > struct synth_event_trace_state > > *trace_state) > > { > > - struct synth_trace_event *entry = trace_state->entry; > > + struct synth_field *field = NULL; > > + struct synth_trace_event *entry; > > + struct synth_event *event; > > + int i, ret = 0; > > + Here's the patch with __synth_event_add_val() made static. Let me know if you want me to just do a v2 of this series.. Thanks, Tom [PATCH] tracing: Consolidate some synth_event_trace code The synth_event trace code contains some almost identical functions and some small functions that are called only once - consolidate the common code into single functions and fold in the small functions to simplify the code overall. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 141 ++++++++++++++++----------------------- 1 file changed, 57 insertions(+), 84 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 5b4e04780411..42058a1b5146 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -2053,24 +2053,72 @@ int synth_event_trace_start(struct trace_event_file *file, } EXPORT_SYMBOL_GPL(synth_event_trace_start); -static int save_synth_val(struct synth_field *field, u64 val, - struct synth_event_trace_state *trace_state) +static int __synth_event_add_val(const char *field_name, u64 val, + struct synth_event_trace_state *trace_state) { - struct synth_trace_event *entry = trace_state->entry; + struct synth_field *field = NULL; + struct synth_trace_event *entry; + struct synth_event *event; + int i, ret = 0; + + if (!trace_state) { + ret = -EINVAL; + goto out; + } + + /* can't mix add_next_synth_val() with add_synth_val() */ + if (field_name) { + if (trace_state->add_next) { + ret = -EINVAL; + goto out; + } + trace_state->add_name = true; + } else { + if (trace_state->add_name) { + ret = -EINVAL; + goto out; + } + trace_state->add_next = true; + } + + if (!trace_state->enabled) + goto out; + + event = trace_state->event; + if (trace_state->add_name) { + for (i = 0; i < event->n_fields; i++) { + field = event->fields[i]; + if (strcmp(field->name, field_name) == 0) + break; + } + if (!field) { + ret = -EINVAL; + goto out; + } + } else { + if (trace_state->cur_field >= event->n_fields) { + ret = -EINVAL; + goto out; + } + field = event->fields[trace_state->cur_field++]; + } + entry = trace_state->entry; if (field->is_string) { char *str_val = (char *)(long)val; char *str_field; - if (!str_val) - return -EINVAL; + if (!str_val) { + ret = -EINVAL; + goto out; + } str_field = (char *)&entry->fields[field->offset]; strscpy(str_field, str_val, STR_VAR_LEN_MAX); } else entry->fields[field->offset] = val; - - return 0; + out: + return ret; } /** @@ -2104,54 +2152,10 @@ static int save_synth_val(struct synth_field *field, u64 val, int synth_event_add_next_val(u64 val, struct synth_event_trace_state *trace_state) { - struct synth_field *field; - struct synth_event *event; - int ret = 0; - - if (!trace_state) { - ret = -EINVAL; - goto out; - } - - /* can't mix add_next_synth_val() with add_synth_val() */ - if (trace_state->add_name) { - ret = -EINVAL; - goto out; - } - trace_state->add_next = true; - - if (!trace_state->enabled) - goto out; - - event = trace_state->event; - - if (trace_state->cur_field >= event->n_fields) { - ret = -EINVAL; - goto out; - } - - field = event->fields[trace_state->cur_field++]; - ret = save_synth_val(field, val, trace_state); - out: - return ret; + return __synth_event_add_val(NULL, val, trace_state); } EXPORT_SYMBOL_GPL(synth_event_add_next_val); -static struct synth_field *find_synth_field(struct synth_event *event, - const char *field_name) -{ - struct synth_field *field = NULL; - unsigned int i; - - for (i = 0; i < event->n_fields; i++) { - field = event->fields[i]; - if (strcmp(field->name, field_name) == 0) - return field; - } - - return NULL; -} - /** * synth_event_add_val - Add a named field's value to an open synth trace * @field_name: The name of the synthetic event field value to set @@ -2183,38 +2187,7 @@ static struct synth_field *find_synth_field(struct synth_event *event, int synth_event_add_val(const char *field_name, u64 val, struct synth_event_trace_state *trace_state) { - struct synth_trace_event *entry; - struct synth_event *event; - struct synth_field *field; - int ret = 0; - - if (!trace_state) { - ret = -EINVAL; - goto out; - } - - /* can't mix add_next_synth_val() with add_synth_val() */ - if (trace_state->add_next) { - ret = -EINVAL; - goto out; - } - trace_state->add_name = true; - - if (!trace_state->enabled) - goto out; - - event = trace_state->event; - entry = trace_state->entry; - - field = find_synth_field(event, field_name); - if (!field) { - ret = -EINVAL; - goto out; - } - - ret = save_synth_val(field, val, trace_state); - out: - return ret; + return __synth_event_add_val(field_name, val, trace_state); } EXPORT_SYMBOL_GPL(synth_event_add_val); -- 2.14.1