From: Auger Eric <eric.auger@redhat.com>
To: Julien Grall <julien.grall@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc: jason@lakedaemon.net, douliyangs@gmail.com, marc.zyngier@arm.com,
robin.murphy@arm.com, miquel.raynal@bootlin.com,
tglx@linutronix.de, logang@deltatee.com, bigeasy@linutronix.de,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2 4/7] irqchip/gic-v3-its: Don't map the MSI page in its_irq_compose_msi_msg()
Date: Tue, 30 Apr 2019 14:34:51 +0200 [thread overview]
Message-ID: <17855fd3-7f7b-a962-e2bd-c9a0c2dbf765@redhat.com> (raw)
In-Reply-To: <20190429144428.29254-5-julien.grall@arm.com>
Hi Julien,
On 4/29/19 4:44 PM, Julien Grall wrote:
> its_irq_compose_msi_msg() may be called from non-preemptible context.
> However, on RT, iommu_dma_map_msi_msg requires to be called from a
> preemptible context.
>
> A recent change split iommu_dma_map_msi_msg() in two new functions:
> one that should be called in preemptible context, the other does
> not have any requirement.
>
> The GICv3 ITS driver is reworked to avoid executing preemptible code in
> non-preemptible context. This can be achieved by preparing the MSI
> maping when allocating the MSI interrupt.
mapping
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
> Changes in v2:
> - Rework the commit message to use imperative mood
> ---
> drivers/irqchip/irq-gic-v3-its.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 7577755bdcf4..12ddbcfe1b1e 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1179,7 +1179,7 @@ static void its_irq_compose_msi_msg(struct irq_data *d, struct msi_msg *msg)
> msg->address_hi = upper_32_bits(addr);
> msg->data = its_get_event_id(d);
>
> - iommu_dma_map_msi_msg(d->irq, msg);
> + iommu_dma_compose_msi_msg(irq_data_get_msi_desc(d), msg);
> }
>
> static int its_irq_set_irqchip_state(struct irq_data *d,
> @@ -2566,6 +2566,7 @@ static int its_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
> {
> msi_alloc_info_t *info = args;
> struct its_device *its_dev = info->scratchpad[0].ptr;
> + struct its_node *its = its_dev->its;
> irq_hw_number_t hwirq;
> int err;
> int i;
> @@ -2574,6 +2575,8 @@ static int its_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
> if (err)
> return err;
>
> + err = iommu_dma_prepare_msi(info->desc, its->get_msi_base(its_dev));
Test err as in gicv2m driver?
> +
> for (i = 0; i < nr_irqs; i++) {
> err = its_irq_gic_domain_alloc(domain, virq + i, hwirq + i);
> if (err)
>
Besides
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
next prev parent reply other threads:[~2019-04-30 12:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:44 [PATCH v2 0/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Julien Grall
2019-04-29 14:44 ` [PATCH v2 1/7] genirq/msi: Add a new field in msi_desc to store an IOMMU cookie Julien Grall
2019-04-29 15:12 ` Robin Murphy
2019-04-30 12:53 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 2/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg() in two parts Julien Grall
2019-04-29 15:16 ` Robin Murphy
2019-04-29 15:28 ` Marc Zyngier
2019-04-30 12:54 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 3/7] irqchip/gicv2m: Don't map the MSI page in gicv2m_compose_msi_msg() Julien Grall
2019-04-30 12:34 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 4/7] irqchip/gic-v3-its: Don't map the MSI page in its_irq_compose_msi_msg() Julien Grall
2019-04-30 12:34 ` Auger Eric [this message]
2019-05-01 11:14 ` Julien Grall
2019-05-01 11:37 ` Marc Zyngier
2019-04-29 14:44 ` [PATCH v2 5/7] irqchip/ls-scfg-msi: Don't map the MSI page in ls_scfg_msi_compose_msg() Julien Grall
2019-04-29 14:44 ` [PATCH v2 6/7] irqchip/gic-v3-mbi: Don't map the MSI page in mbi_compose_m{b, s}i_msg() Julien Grall
2019-04-29 14:44 ` [PATCH v2 7/7] iommu/dma-iommu: Remove iommu_dma_map_msi_msg() Julien Grall
2019-04-29 15:19 ` Robin Murphy
2019-04-30 13:38 ` Auger Eric
2019-04-29 15:57 ` [PATCH v2 0/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Marc Zyngier
2019-04-29 19:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17855fd3-7f7b-a962-e2bd-c9a0c2dbf765@redhat.com \
--to=eric.auger@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=douliyangs@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=marc.zyngier@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).