From: Kurt Kanzenbach <kurt@linutronix.de>
To: John Kacur <jkacur@redhat.com>, Clark Williams <williams@redhat.com>
Cc: rt-users <linux-rt-users@vger.kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: [PATCH 5/6] rt-tests: cyclicdeadline: Print fail only if something failed
Date: Tue, 18 Jun 2019 12:38:40 +0200 [thread overview]
Message-ID: <20190618103841.27249-6-kurt@linutronix.de> (raw)
In-Reply-To: <20190618103841.27249-1-kurt@linutronix.de>
It is interesting to see what went wrong in case something did. However, the
fail statement is printed always. That is confusing.
Furthermore, the fail value is always 1 when a failure happened. There is no
need to print it.
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
src/sched_deadline/cyclicdeadline.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index 7cffe826b944..16d986a02244 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -1204,10 +1204,11 @@ int main (int argc, char **argv)
printf("main thread %d\n", gettid());
pthread_barrier_wait(&barrier);
- printf("fail 2 %d\n", fail);
- if (fail)
+ if (fail) {
+ printf("fail 2\n");
exit(-1);
+ }
pthread_barrier_wait(&barrier);
--
2.11.0
next prev parent reply other threads:[~2019-06-18 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 10:38 [PATCH 0/6] rt-tests: deadline: Cleanups Kurt Kanzenbach
2019-06-18 10:38 ` [PATCH 1/6] rt-tests: deadline: Remove duplicated code for sched_{set,get}_attr Kurt Kanzenbach
2019-06-19 15:46 ` John Kacur
2019-06-18 10:38 ` [PATCH 2/6] rt-tests: cyclicdeadline: Remove unused getcpu code Kurt Kanzenbach
2019-06-19 15:46 ` John Kacur
2019-06-18 10:38 ` [PATCH 3/6] rt-tests: deadline: Remove duplicated gettid() code Kurt Kanzenbach
2019-06-19 15:48 ` John Kacur
2019-06-24 13:40 ` Sebastian Andrzej Siewior
2019-06-25 9:29 ` John Kacur
2019-06-25 13:52 ` Sebastian Andrzej Siewior
2019-06-18 10:38 ` [PATCH 4/6] rt-tests: cyclicdeadline: Add options to usage Kurt Kanzenbach
2019-06-19 15:48 ` John Kacur
2019-06-18 10:38 ` Kurt Kanzenbach [this message]
2019-06-19 15:49 ` [PATCH 5/6] rt-tests: cyclicdeadline: Print fail only if something failed John Kacur
2019-06-18 10:38 ` [PATCH 6/6] rt-tests: cyclicdeadline: Fix cgroup setup Kurt Kanzenbach
2019-06-19 15:49 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618103841.27249-6-kurt@linutronix.de \
--to=kurt@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).