SCHED_DEADLINE inactive timer needs to run in hardirq context (as dl_task_timer already does). Make it HRTIMER_MODE_REL_HARD. Signed-off-by: Juri Lelli <juri.lelli@redhat.com> --- Hi, Both v4.19-rt and v5.2-rt need this. Mainline "sched: Mark hrtimers to expire in hard interrupt context" series needs this as well (20190726185753.077004842@linutronix.de in particular). Do I need to send out a separate patch for it? Best, Juri --- kernel/sched/deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 1794e152d888..0889674b8915 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se) { struct hrtimer *timer = &dl_se->inactive_timer; - hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); + hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD); timer->function = inactive_task_timer; } -- 2.17.2
On 31/07/2019 12:37, Juri Lelli wrote:
> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
>
> Make it HRTIMER_MODE_REL_HARD.
>
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Acked-by: Daniel Bristot de Oliveira <bristot@redhat.com>
-- Daniel
On Wed, 31 Jul 2019 12:37:15 +0200
Juri Lelli <juri.lelli@redhat.com> wrote:
> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
>
> Make it HRTIMER_MODE_REL_HARD.
>
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
> ---
> Hi,
>
> Both v4.19-rt and v5.2-rt need this.
>
> Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> series needs this as well (20190726185753.077004842@linutronix.de in
> particular). Do I need to send out a separate patch for it?
>
> Best,
>
> Juri
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 1794e152d888..0889674b8915 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se)
> {
> struct hrtimer *timer = &dl_se->inactive_timer;
>
> - hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> + hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
> timer->function = inactive_task_timer;
> }
>
> --
> 2.17.2
>
Acked-by: Clark Williams <williams@redhat.com>
--
The United States Coast Guard
Ruining Natural Selection since 1790
On 2019-07-31 12:37:15 [+0200], Juri Lelli wrote: > Hi, Hi, > Both v4.19-rt and v5.2-rt need this. > > Mainline "sched: Mark hrtimers to expire in hard interrupt context" > series needs this as well (20190726185753.077004842@linutronix.de in > particular). Do I need to send out a separate patch for it? time will show. I applied it now to my tree and will ping tglx later… > Best, > > Juri Sebastian
On 13/08/19 15:09, Sebastian Andrzej Siewior wrote: > On 2019-07-31 12:37:15 [+0200], Juri Lelli wrote: > > Hi, > Hi, > > > Both v4.19-rt and v5.2-rt need this. > > > > Mainline "sched: Mark hrtimers to expire in hard interrupt context" > > series needs this as well (20190726185753.077004842@linutronix.de in > > particular). Do I need to send out a separate patch for it? > > time will show. I applied it now to my tree and will ping tglx later… Thanks. tglx actually already applied it to tip (with a fixup): https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=4394ba872c36255d25c6bde151b061f04655ebfb Best, Juri