From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E6DC3A589 for ; Thu, 15 Aug 2019 15:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41D092084D for ; Thu, 15 Aug 2019 15:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732580AbfHOPPT (ORCPT ); Thu, 15 Aug 2019 11:15:19 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:39990 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732578AbfHOPPS (ORCPT ); Thu, 15 Aug 2019 11:15:18 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1hyHT9-00080j-Il; Thu, 15 Aug 2019 17:15:16 +0200 Date: Thu, 15 Aug 2019 17:15:15 +0200 From: Sebastian Andrzej Siewior To: Paul Thomas Cc: John Ogness , Thomas Gleixner , linux-rt-users , dunc.mcphie@gmail.com, Anders Roxell Subject: Re: poor cyclictest results with 5.0 series rt for arm64 Message-ID: <20190815151515.p2tch5qz653h2unm@linutronix.de> References: <20190813095306.xqgq3uusdpj7dhy7@linutronix.de> <20190814112656.z3de2rgbqzpaquz5@linutronix.de> <20190815082955.olo3phbqj6disk3q@linutronix.de> <87a7ca4nh6.fsf@linutronix.de> <20190815134248.abwbufgwh4zybj4g@linutronix.de> <20190815141923.yu6obojglb2hjsia@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On 2019-08-15 11:12:35 [-0400], Paul Thomas wrote: > > so it seems to works but I *think* that at 610.156813 shouldn't be there > > and it should switch to cyclictest. But if it is the broken irq-exit > > path then this should fix it: > > > > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > > index 63c6960262861..27a16c2711981 100644 > > --- a/arch/arm64/kernel/entry.S > > +++ b/arch/arm64/kernel/entry.S > > @@ -649,13 +649,7 @@ alternative_if ARM64_HAS_IRQ_PRIO_MASKING > > alternative_else_nop_endif > > > > cbz x24, 1f // (need_resched + count) == 0 > > - cbnz w24, 2f // count != 0 > > - > > - ldr w24, [tsk, #TSK_TI_PREEMPT_LAZY] // get preempt lazy count > > - cbnz w24, 2f // preempt lazy count != 0 > > - > > - ldr x0, [tsk, #TSK_TI_FLAGS] // get flags > > - tbz x0, #TIF_NEED_RESCHED_LAZY, 2f // needs rescheduling? > > + b 2f // count != 0 > > 1: > > bl preempt_schedule_irq // irq en/disable is done inside > > 2: > This doesn't look like it's against 5.2.y-rt or 5.0.y-rt? I don't see > a (need_resched + count) == 0 line? That was the previous patch I've sent you. > -Paul Sebastian