From: Clark Williams <clark.williams@gmail.com>
To: bigeasy@linutronix.com
Cc: tglx@linutronix.com, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PREEMPT_RT PATCH 0/3] i915 fixups for lockdep/lockdebugging
Date: Mon, 19 Aug 2019 19:33:16 -0500 [thread overview]
Message-ID: <20190820003319.24135-1-clark.williams@gmail.com> (raw)
From: Clark Williams <williams@redhat.com>
The i915 driver was throwing splats on my home test box running
v5.2-rt3 when I turned on lockdep and lock debugging configs. This was
mainly due to the non-side effects of the spin*_irq*() macros which do
nothing to IRQs on PREEMPT_RT. Converting the various irq_lock spinlocks
and the uncore lock to be raw_spinlock_t fixes this, although I'm not
sure of the performance implications for latency spikes.
Testing was done on an Intel NUC with the following graphics:
00:02.0 VGA compatible controller: Intel Corporation Iris Plus Graphics 650 (rev 06)
Testing on other variants of i915 would be appreciated.
Clark Williams (3):
i915: do not call lockdep_assert_irqs_disabled() on PREEMPT_RT
i915: convert all irq_locks spinlocks to raw spinlocks
i915: convert uncore lock to raw spinlock
drivers/gpu/drm/i915/i915_debugfs.c | 8 +-
drivers/gpu/drm/i915/i915_drv.c | 6 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 4 +-
drivers/gpu/drm/i915/i915_irq.c | 154 ++++++++++-----------
drivers/gpu/drm/i915/i915_pmu.c | 4 +-
drivers/gpu/drm/i915/intel_breadcrumbs.c | 51 +++----
drivers/gpu/drm/i915/intel_display.c | 20 +--
drivers/gpu/drm/i915/intel_engine_cs.c | 4 +-
drivers/gpu/drm/i915/intel_engine_types.h | 2 +-
drivers/gpu/drm/i915/intel_fifo_underrun.c | 16 +--
drivers/gpu/drm/i915/intel_guc.c | 6 +-
drivers/gpu/drm/i915/intel_guc.h | 10 +-
drivers/gpu/drm/i915/intel_hotplug.c | 36 ++---
drivers/gpu/drm/i915/intel_pm.c | 8 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 8 +-
drivers/gpu/drm/i915/intel_sprite.c | 32 ++---
drivers/gpu/drm/i915/intel_tv.c | 8 +-
drivers/gpu/drm/i915/intel_uncore.c | 52 +++----
drivers/gpu/drm/i915/intel_uncore.h | 2 +-
drivers/gpu/drm/i915/intel_workarounds.c | 4 +-
21 files changed, 220 insertions(+), 217 deletions(-)
--
2.21.0
next reply other threads:[~2019-08-20 0:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 0:33 Clark Williams [this message]
2019-08-20 0:33 ` [PREEMPT_RT PATCH 1/3] i915: do not call lockdep_assert_irqs_disabled() on PREEMPT_RT Clark Williams
2019-09-25 16:47 ` Sebastian Andrzej Siewior
2019-08-20 0:33 ` [PREEMPT_RT PATCH 2/3] i915: convert all irq_locks spinlocks to raw spinlocks Clark Williams
2019-09-03 8:03 ` Sebastian Andrzej Siewior
2019-09-03 13:09 ` Sebastian Andrzej Siewior
2019-09-16 21:21 ` Sean V Kelley
2019-09-27 12:29 ` Sebastian Andrzej Siewior
[not found] ` <CAPAFJkofsYgSOxzM4JDkOV3Ra0C-AEpU2eZJjR9F9e_qv-6=rg@mail.gmail.com>
2019-09-27 15:18 ` Sean V Kelley
2019-08-20 0:33 ` [PREEMPT_RT PATCH 3/3] i915: convert uncore lock to raw spinlock Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820003319.24135-1-clark.williams@gmail.com \
--to=clark.williams@gmail.com \
--cc=bigeasy@linutronix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).