Linux-rt-users archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default
@ 2019-09-19 18:31 John Kacur
  2019-09-23 14:18 ` Sebastian Andrzej Siewior
  0 siblings, 1 reply; 2+ messages in thread
From: John Kacur @ 2019-09-19 18:31 UTC (permalink / raw)
  To: rt-users; +Cc: Clark Williams, John Kacur

Most distributions have used libnuma version 2 for awhile now, so make
it the default.

This doesn't prevent people from defining it as version 1, or compiling
without numa.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/cyclictest/rt_numa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
index e0f4b2e9d8b2..7adeb3c01324 100644
--- a/src/cyclictest/rt_numa.h
+++ b/src/cyclictest/rt_numa.h
@@ -29,7 +29,7 @@ static int numa = 0;
 #include <numa.h>
 
 #ifndef LIBNUMA_API_VERSION
-#define LIBNUMA_API_VERSION 1
+#define LIBNUMA_API_VERSION 2
 #endif
 
 static void *
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default
  2019-09-19 18:31 [PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default John Kacur
@ 2019-09-23 14:18 ` Sebastian Andrzej Siewior
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2019-09-23 14:18 UTC (permalink / raw)
  To: John Kacur; +Cc: rt-users, Clark Williams

On 2019-09-19 20:31:14 [+0200], John Kacur wrote:
> Most distributions have used libnuma version 2 for awhile now, so make
> it the default.
> 
> This doesn't prevent people from defining it as version 1, or compiling
> without numa.

"LIBNUMA_API_VERSION 2" was introduced in version v2.0.2 of the numactl
package. "LIBNUMA_API_VERSION 1" was never defined.
The version v2.0.2 was released in late 2008 as in more than a decade
ago. Therefore I would suggest to just drop that compatibility layer and
depend on the new API version. So if libnuma is used then the "one"
please, otherwise no libnuma.

Sebastian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 18:31 [PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default John Kacur
2019-09-23 14:18 ` Sebastian Andrzej Siewior

Linux-rt-users archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git