[PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default

[PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default

[John Kacur]

Most distributions have used libnuma version 2 for awhile now, so make
it the default.

This doesn't prevent people from defining it as version 1, or compiling
without numa.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/cyclictest/rt_numa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
index e0f4b2e9d8b2..7adeb3c01324 100644
--- a/src/cyclictest/rt_numa.h
+++ b/src/cyclictest/rt_numa.h
@@ -29,7 +29,7 @@ static int numa = 0;
 #include <numa.h>
 
 #ifndef LIBNUMA_API_VERSION
-#define LIBNUMA_API_VERSION 1
+#define LIBNUMA_API_VERSION 2
 #endif
 
 static void *
-- 
2.20.1

Re: [PATCH] rt-tests: cyclictest: Assume libnuma version 2 by default

[Sebastian Andrzej Siewior]

On 2019-09-19 20:31:14 [+0200], John Kacur wrote:
> Most distributions have used libnuma version 2 for awhile now, so make
> it the default.
> 
> This doesn't prevent people from defining it as version 1, or compiling
> without numa.

"LIBNUMA_API_VERSION 2" was introduced in version v2.0.2 of the numactl
package. "LIBNUMA_API_VERSION 1" was never defined.
The version v2.0.2 was released in late 2008 as in more than a decade
ago. Therefore I would suggest to just drop that compatibility layer and
depend on the new API version. So if libnuma is used then the "one"
please, otherwise no libnuma.

Sebastian