From: Daniel Wagner <email@example.com> To: Uladzislau Rezki <firstname.lastname@example.org> Cc: Sebastian Andrzej Siewior <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Andrew Morton <email@example.com> Subject: Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node Date: Mon, 7 Oct 2019 18:34:43 +0200 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20191007162330.GA26503@pc636> On Mon, Oct 07, 2019 at 06:23:30PM +0200, Uladzislau Rezki wrote: > Hello, Daniel, Sebastian. > > > > On Fri, Oct 04, 2019 at 06:30:42PM +0200, Sebastian Andrzej Siewior wrote: > > > > On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote: > > > > > If we have migrate_disable/enable, then, i think preempt_enable/disable > > > > > should be replaced by it and not the way how it has been proposed > > > > > in the patch. > > > > > > > > I don't think this patch is appropriate for upstream. > > > > > > Yes, I agree. The discussion made this clear, this is only for -rt > > > trees. Initially I though this should be in mainline too. > > > > Sorry, this was _before_ Uladzislau pointed out that you *just* moved > > the lock that was there from the beginning. I missed that while looking > > over the patch. Based on that I don't think that this patch is not > > appropriate for upstream. > > > Yes that is a bit messy :) Then i do not see what that patch fixes in > mainline? Instead it will just add an extra blocking, i did not want that > therefore used preempt_enable/disable. But, when i saw this patch i got it > as a preparation of PREEMPT_RT merging work. Maybe I should add some background info here as well. Currently, I am creating an -rt tree on v5.3 for which I need this patch (or a migrate_disable() version of it). So this is slightly independent of the work Sebiastian is doing. Though the mainline effort of PREEMPT_RT will hit this problem as well. I understood Sebiastian wrong above. I thought he suggest to use the migrate_disable() approach even for mainline. I supppose, one thing which would help in this discussion, is what do you gain by using preempt_disable() instead of moving the lock up? Do you have performance numbers which could justify the code?
next prev parent reply index Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-03 9:09 Daniel Wagner 2019-10-03 11:55 ` Uladzislau Rezki 2019-10-04 15:37 ` Sebastian Andrzej Siewior 2019-10-04 16:20 ` Uladzislau Rezki 2019-10-04 16:30 ` Sebastian Andrzej Siewior 2019-10-04 17:04 ` Uladzislau Rezki 2019-10-04 17:45 ` Sebastian Andrzej Siewior 2019-10-07 8:30 ` Daniel Wagner 2019-10-07 10:56 ` Sebastian Andrzej Siewior 2019-10-07 16:23 ` Uladzislau Rezki 2019-10-07 16:34 ` Daniel Wagner [this message] 2019-10-07 16:56 ` Uladzislau Rezki 2019-10-07 17:22 ` Daniel Wagner 2019-10-07 17:36 ` Sebastian Andrzej Siewior 2019-10-07 21:44 ` Uladzislau Rezki 2019-10-08 16:04 ` Uladzislau Rezki 2019-10-09 6:05 ` Daniel Wagner 2019-10-09 9:47 ` Uladzislau Rezki 2019-10-07 8:27 ` Daniel Wagner
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-rt-users archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \ email@example.com firstname.lastname@example.org public-inbox-index linux-rt-users Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users AGPL code for this site: git clone https://public-inbox.org/ public-inbox