From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12C5C2D0CE for ; Tue, 21 Jan 2020 16:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D185524653 for ; Tue, 21 Jan 2020 16:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729207AbgAUQ55 (ORCPT ); Tue, 21 Jan 2020 11:57:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:35494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729081AbgAUQ55 (ORCPT ); Tue, 21 Jan 2020 11:57:57 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0C5921569; Tue, 21 Jan 2020 16:57:55 +0000 (UTC) Date: Tue, 21 Jan 2020 11:57:54 -0500 From: Steven Rostedt To: Tom Zanussi Cc: artem.bityutskiy@linux.intel.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 06/12] tracing: Add synthetic event command generation functions Message-ID: <20200121115754.01efcdfd@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Fri, 10 Jan 2020 14:35:12 -0600 Tom Zanussi wrote: > Add functions used to generate synthetic event commands, built on top > of the dynevent_cmd interface. > > gen_synth_cmd() is used to create a synthetic event command using a > variable arg list and gen_synth_cmd_array() does the same thing but > using an array of field descriptors. add_synth_field() and > add_synth_fields() can be used to add single fields one by one or as a > group. Once all desired fields are added, create_dynevent() is used > to actually execute the command and create the event. > > create_synth_event() does everything, including creating the event, in > a single call. > > Signed-off-by: Tom Zanussi > --- > include/linux/trace_events.h | 30 ++++ > kernel/trace/trace_events_hist.c | 325 ++++++++++++++++++++++++++++++++++++++- > 2 files changed, 352 insertions(+), 3 deletions(-) > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h > index bf4cc2e56125..4228407d4736 100644 > --- a/include/linux/trace_events.h > +++ b/include/linux/trace_events.h > @@ -409,6 +409,36 @@ extern int create_dynevent(struct dynevent_cmd *cmd); > > extern int delete_synth_event(const char *name); > > +extern void synth_dynevent_cmd_init(struct dynevent_cmd *cmd, > + char *buf, int maxlen); > + > +extern int __gen_synth_cmd(struct dynevent_cmd *cmd, const char *name, > + struct module *mod, ...); > + > +#define gen_synth_cmd(cmd, name, mod, ...) \ > + __gen_synth_cmd(cmd, name, mod, ## __VA_ARGS__, NULL) > + > +struct synth_field_desc { > + const char *type; > + const char *name; > +}; > + > +extern int gen_synth_cmd_array(struct dynevent_cmd *cmd, const char *name, > + struct module *mod, > + struct synth_field_desc *fields, > + unsigned int n_fields); > +extern int create_synth_event(const char *name, > + struct synth_field_desc *fields, > + unsigned int n_fields, struct module *mod); > + > + > +extern int add_synth_field(struct dynevent_cmd *cmd, > + const char *type, > + const char *name); > +extern int add_synth_fields(struct dynevent_cmd *cmd, > + struct synth_field_desc *fields, > + unsigned int n_fields); As these are in a global header and globally visible, let's rename them to be more name space aware. Have them all start with "synth_event_". synth_event_gen_cmd_array() synth_event_create() synth_event_add_field() synth_event_add_fields() Makes it easier to grep for synth_event functions too. -- Steve > + > /* > * Event file flags: > * ENABLED - The event is enabled