Linux-rt-users archive on lore.kernel.org
 help / color / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Joe Korty <joe.korty@concurrent-rt.com>,
	Tom Zanussi <zanussi@kernel.org>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 4.14-rt] Fix wrong-variable use in irq_set_affinity_notifier
Date: Tue, 11 Feb 2020 18:49:15 +0100
Message-ID: <20200211174915.mh5bntkysztjmjdd@linutronix.de> (raw)
In-Reply-To: <20200211140007.GA6791@zipoli.concurrent-rt.com>

On 2020-02-11 09:00:07 [-0500], Joe Korty wrote:
> 4.14-rt: Fix wrong-variable use in irq_set_affinity_notifier.
> 
> The bug was introduced in the 4.14-rt patch
>  
>    0461-genirq-Handle-missing-work_struct-in-irq_set_affinit.patch
> 
> The symptom is a NULL pointer panic in the i40e driver on
> system shutdown.
> 4.19-rt and above do not have this problem due to a refactoring.

That would be Tom's to pick. Is v4.14-RT the only one affected? I was
under the impression that we fixed it already in each stable rt tree.

> Signed-off-by: Joe Korty <Joe.Korty@concurrent-rt.com>
> 
> Index: b/kernel/irq/manage.c
> ===================================================================
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -353,7 +353,7 @@ irq_set_affinity_notifier(unsigned int i
>  
>  	if (old_notify) {
>  #ifdef CONFIG_PREEMPT_RT_BASE
> -		kthread_cancel_work_sync(&notify->work);
> +		kthread_cancel_work_sync(&old_notify->work);
>  #else
>  		cancel_work_sync(&old_notify->work);
>  #endif

Sebastian

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 14:00 Joe Korty
2020-02-11 17:49 ` Sebastian Andrzej Siewior [this message]
2020-02-11 18:40   ` Joe Korty
2020-02-11 20:06     ` Tom Zanussi

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211174915.mh5bntkysztjmjdd@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=joe.korty@concurrent-rt.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-rt-users archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git