From: Petr Mladek <pmladek@suse.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-rt-users@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: Question about kthread_mod_delayed_work() allowed context
Date: Thu, 13 Feb 2020 09:33:33 +0100 [thread overview]
Message-ID: <20200213083333.jglatxs5j76z2634@pathway.suse.cz> (raw)
In-Reply-To: <59802c56-1013-3042-167d-89f288f51b58@ti.com>
On Wed 2020-02-12 21:17:53, Grygorii Strashko wrote:
>
>
> On 12/02/2020 17:41, Petr Mladek wrote:
> > On Tue 2020-02-11 12:23:59, Grygorii Strashko wrote:
> > > Hi All,
> > >
> > > I'd like to ask question about allowed calling context for kthread_mod_delayed_work().
> > >
> > > The comment to kthread_mod_delayed_work() says:
> > >
> > > * This function is safe to call from any context including IRQ handler.
> > > * See __kthread_cancel_work() and kthread_delayed_work_timer_fn()
> > > * for details.
> > > */
> > >
> > > But it has del_timer_sync() inside which seems can't be called from hard_irq context:
> > > kthread_mod_delayed_work()
> > > |-__kthread_cancel_work()
> > > |- del_timer_sync()
> > > |- WARN_ON(in_irq() && !(timer->flags & TIMER_IRQSAFE));
> >
> > It is safe because kthread_delayed_work_timer_fn() is IRQ safe.
> > Note that it uses raw_spin_lock_irqsave(). It is the reason why
> > the timer could have set TIMER_IRQSAFE flag, see
> > KTHREAD_DELAYED_WORK_INIT().
> >
> > In more details. The timer is either canceled before the callback
> > is called. Or it waits for the callback but the callback is safe
> > because it can't sleep.
>
> I think, my issue (warning) could be related to the fact that kthread_init_delayed_work()
> is used, which seems doesn't set TIMER_IRQSAFE flag.
Great catch!
It is a bug. Would you like to send the fix for
kthread_init_delayed_work() or would you prefer me doing so?
Best Regards,
Petr
prev parent reply other threads:[~2020-02-13 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 10:23 Question about kthread_mod_delayed_work() allowed context Grygorii Strashko
2020-02-12 15:41 ` Petr Mladek
2020-02-12 19:17 ` Grygorii Strashko
2020-02-13 8:33 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213083333.jglatxs5j76z2634@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).