From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
tglx@linutronix.de, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] powerpc: Fix lazy preemption for powerpc 32bit
Date: Thu, 19 Mar 2020 15:24:52 +0100 [thread overview]
Message-ID: <20200319142452.dqmkuruts3i6wjyt@linutronix.de> (raw)
In-Reply-To: <0c91d808-b077-408c-b120-99e806efaeb5@EXC03-ATKLA.omicron.at>
On 2020-03-18 21:26:40 [+0100], Thomas Graziadei wrote:
> From: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
>
> The 32bit powerpc assembler implementation of the lazy preemption
> set the _TIF_PERSYSCALL_MASK on the low word. This could lead to
> modprobe segfaults and a kernel panic - not syncing: Attempt to
> kill init! issue.
>
> Fixed by shifting the mask by 16 bit using andis and lis.
bah. Thank you for catching this.
Still e500 based powerpc I assume?
> Signed-off-by: Thomas Graziadei <thomas.graziadei@omicronenergy.com>
Sebastian
next prev parent reply other threads:[~2020-03-19 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:26 [PATCH] powerpc: Fix lazy preemption for powerpc 32bit Thomas Graziadei
2020-03-19 14:24 ` Sebastian Andrzej Siewior [this message]
2020-03-19 14:45 ` Thomas Graziadei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319142452.dqmkuruts3i6wjyt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thomas.graziadei@omicronenergy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).