From: Pavel Machek <pavel@denx.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Pavel Machek <pavel@denx.de>,
ben.hutchings@codethink.co.uk, Chris.Paterson2@renesas.com,
bigeasy@linutronix.de, LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Julia Cartwright <julia@ni.com>, Daniel Wagner <wagi@monom.org>,
Tom Zanussi <zanussi@kernel.org>,
"Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
Subject: Re: 4.19.106-rt44 -- boot problems with irqwork: push most work into softirq context
Date: Sat, 21 Mar 2020 23:43:40 +0100 [thread overview]
Message-ID: <20200321224339.GA20728@duo.ucw.cz> (raw)
In-Reply-To: <20200320160545.26a65de3@gandalf.local.home>
[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]
Hi!
On Fri 2020-03-20 16:05:45, Steven Rostedt wrote:
> On Fri, 20 Mar 2020 20:54:32 +0100
> Pavel Machek <pavel@denx.de> wrote:
>
> > > Does this patch help?
> >
> > I don't think so. It also failed, and the failure seems to be
> > identical to me.
> >
> > https://gitlab.com/cip-project/cip-kernel/linux-cip/tree/ci/pavel/linux-cip
> > https://lava.ciplatform.org/scheduler/job/13110
> >
>
> Can you send me a patch that shows the difference between the revert that
> you say works, and the upstream v4.19-rt tree (let me know which version
> of v4.19-rt you are basing it on).
I was using -rt44, and yes, I can probably generate better diffs.
But I guess I found it with code review: how does this look to you? I
applied it on top of your fix, and am testing. 2 successes so far.
Signed-off-by: Pavel Machek <pavel@denx.de>
Best regards,
Pavel
commit aa034c3060dbab96a7b6d6bf827504b394bed15b
Author: Pavel Machek <pavel@ucw.cz>
Date: Sat Mar 21 22:58:43 2020 +0100
It sounds like irq_work_queue() was queueing on wrong list?
diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 0ca75c77536b..dd654865c219 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -81,7 +81,8 @@ bool irq_work_queue(struct irq_work *work)
/* Queue the entry and raise the IPI if needed. */
preempt_disable();
- if (IS_ENABLED(CONFIG_PREEMPT_RT_FULL) && !(work->flags & IRQ_WORK_HARD_IRQ))
+ if ((IS_ENABLED(CONFIG_PREEMPT_RT_FULL) && !(work->flags & IRQ_WORK_HARD_IRQ))
+ || (work->flags & IRQ_WORK_LAZY))
list = this_cpu_ptr(&lazy_list);
else
list = this_cpu_ptr(&raised_list);
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-03-21 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 22:08 [ANNOUNCE] 4.19.106-rt44 Steven Rostedt
2020-03-19 21:48 ` Pavel Machek
2020-03-19 23:22 ` 4.19.106-rt44 -- boot problems with irqwork: push most work into softirq context Pavel Machek
2020-03-20 0:48 ` Steven Rostedt
2020-03-20 19:54 ` Pavel Machek
2020-03-20 20:05 ` Steven Rostedt
2020-03-21 22:43 ` Pavel Machek [this message]
2020-03-21 23:00 ` Pavel Machek
2020-03-29 10:09 ` 4.4-rt ... seems to have same ireqwork problem was " Pavel Machek
2020-03-30 20:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321224339.GA20728@duo.ucw.cz \
--to=pavel@denx.de \
--cc=C.Emde@osadl.org \
--cc=Chris.Paterson2@renesas.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).