From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Liwei Song <liwei.song@windriver.com>
Cc: linux-rt <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH RT] mm: do not warn for suspend when allocate memory on RT
Date: Thu, 16 Apr 2020 19:09:43 +0200 [thread overview]
Message-ID: <20200416170943.hjoytlggvfzzdqjt@linutronix.de> (raw)
In-Reply-To: <20200413041817.27514-1-liwei.song@windriver.com>
On 2020-04-13 12:18:17 [+0800], Liwei Song wrote:
> Interrupts are off during resume from RAM, this will triger a warning
> when allocate memory in non-preemptible context on RT since commit
> b5d5bc970f209 ("mm: Warn on memory allocation in non-preemptible
> context on RT"), exclude suspend from this warning check.
Is this the ACPI backtrace or do you have something else?
I'm currently not 100% sure if we can skip the warning.
> Fixes: b5d5bc970f209 ("mm: Warn on memory allocation in non-preemptible context on RT")
> Signed-off-by: Liwei Song <liwei.song@windriver.com>
> ---
> mm/slub.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 1929645daa53..ebff24ae50ea 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2771,7 +2771,8 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s,
> unsigned long tid;
>
> if (IS_ENABLED(CONFIG_PREEMPT_RT) && IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP))
> - WARN_ON_ONCE(!preemptible() && system_state >= SYSTEM_SCHEDULING);
> + WARN_ON_ONCE(!preemptible() && system_state >= SYSTEM_SCHEDULING &&
> + system_state != SYSTEM_SUSPEND);
>
> s = slab_pre_alloc_hook(s, gfpflags);
> if (!s)
> @@ -3236,7 +3237,8 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size,
> int i;
>
> if (IS_ENABLED(CONFIG_PREEMPT_RT) && IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP))
> - WARN_ON_ONCE(!preemptible() && system_state >= SYSTEM_SCHEDULING);
> + WARN_ON_ONCE(!preemptible() && system_state >= SYSTEM_SCHEDULING &&
> + system_state != SYSTEM_SUSPEND);
>
> /* memcg and kmem_cache debug support */
> s = slab_pre_alloc_hook(s, flags);
Sebastian
next prev parent reply other threads:[~2020-04-16 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 4:18 [PATCH RT] mm: do not warn for suspend when allocate memory on RT Liwei Song
2020-04-16 17:09 ` Sebastian Andrzej Siewior [this message]
2020-04-17 2:50 ` Liwei Song
2020-04-21 14:51 ` Sebastian Andrzej Siewior
2020-04-24 9:09 ` Liwei Song
2020-05-04 14:53 ` [PATCH RT] mm: Don't warn about atomic memory allocations during suspend Sebastian Andrzej Siewior
2020-05-05 3:59 ` Liwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416170943.hjoytlggvfzzdqjt@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=liwei.song@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).