From: Jiafei Pan <Jiafei.Pan@nxp.com>
To: peterz@infradead.org, mingo@kernel.org, tglx@linutronix.de,
rostedt@goodmis.org, romain.perier@gmail.com, will@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
jiafei.pan@nxp.com, leoyang.li@nxp.com, vladimir.oltean@nxp.com,
Jiafei Pan <Jiafei.Pan@nxp.com>
Subject: [PATCH v2] softirq: add irq off checking for __raise_softirq_irqoff
Date: Fri, 14 Aug 2020 12:55:22 +0800 [thread overview]
Message-ID: <20200814045522.45719-1-Jiafei.Pan@nxp.com> (raw)
__raise_softirq_irqoff() will update per-CPU mask of pending softirqs,
it need to be called in irq disabled context in order to keep it atomic
operation, otherwise it will be interrupted by hardware interrupt,
and per-CPU softirqs pending mask will be corrupted, the result is
there will be unexpected issue, for example hrtimer soft irq will
be losed and soft hrtimer will never be expire and handled.
Enable CONFIG_PROVE_LOCKING to use lockdep_assert_irqs_disabled() to
check hardirqs and softirqs status, and provide warning in irqs enabled
context.
Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
---
Changes in v2:
- use lockdep_assert_irqs_disabled()
- removed extra comments
- changed commit message
kernel/softirq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index bf88d7f62433..09229ad82209 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -481,6 +481,7 @@ void raise_softirq(unsigned int nr)
void __raise_softirq_irqoff(unsigned int nr)
{
+ lockdep_assert_irqs_disabled();
trace_softirq_raise(nr);
or_softirq_pending(1UL << nr);
}
--
2.17.1
next reply other threads:[~2020-08-14 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 4:55 Jiafei Pan [this message]
2020-09-10 2:30 ` [PATCH v2] softirq: add irq off checking for __raise_softirq_irqoff Jiafei Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814045522.45719-1-Jiafei.Pan@nxp.com \
--to=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=romain.perier@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).