From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: v5.9-rc3-rt3 boot time networking lockdep splat
Date: Tue, 8 Sep 2020 14:19:02 +0200 [thread overview]
Message-ID: <20200908121902.zlfd3balosnu7ies@linutronix.de> (raw)
In-Reply-To: <46a2b89ec8d953a4be18c7389c7d8c66310a7ff0.camel@gmx.de>
On 2020-09-05 06:47:29 [+0200], Mike Galbraith wrote:
> [ 22.024936] ======================================================
> [ 22.024936] WARNING: possible circular locking dependency detected
> [ 22.024937] 5.9.0.gc70672d-rt3-rt #8 Tainted: G E
> [ 22.024938] ------------------------------------------------------
> [ 22.024939] ksoftirqd/0/10 is trying to acquire lock:
> [ 22.024941] ffff983475521278 (&sch->q.lock){+...}-{0:0}, at: sch_direct_xmit+0x81/0x2f0
> [ 22.024947]
> but task is already holding lock:
> [ 22.024947] ffff9834755212b8 (&s->seqcount#9){+...}-{0:0}, at: br_dev_queue_push_xmit+0x7d/0x180 [bridge]
> [ 22.024959]
> which lock already depends on the new lock.
>
> [ 22.024960]
> the existing dependency chain (in reverse order) is:
> [ 22.024961]
> -> #1 (&s->seqcount#9){+...}-{0:0}:
> [ 22.024963] lock_acquire+0x92/0x3f0
> [ 22.024967] __dev_queue_xmit+0xce7/0xe30
…
> -> #0 (&sch->q.lock){+...}-{0:0}:
> [ 22.025015] validate_chain+0xa81/0x1230
> [ 22.025016] __lock_acquire+0x880/0xbf0
> [ 22.025017] lock_acquire+0x92/0x3f0
> [ 22.025018] rt_spin_lock+0x78/0xd0
> [ 22.025020] sch_direct_xmit+0x81/0x2f0
…
> other info that might help us debug this:
>
> [ 22.025061] Possible unsafe locking scenario:
>
> [ 22.025061] CPU0 CPU1
> [ 22.025061] ---- ----
> [ 22.025062] lock(&s->seqcount#9);
> [ 22.025064] lock(&sch->q.lock);
> [ 22.025065] lock(&s->seqcount#9);
> [ 22.025065] lock(&sch->q.lock);
> [ 22.025066]
> *** DEADLOCK ***
This has nothing to do with the bridge but with the fact that you use a
non standard queue class (something else than pfifo_fast).
The flow in CPU1 is the default flow but the second lock is a trylock.
CPU0 is from sch_direct_xmit() where it drops the the
root_lock/qdisc.lock and re-acquires it. This shouldn't fail because the
CPU1 a try-lock of the seqlock first and then the seqcount is "not
acquired". So if we annotate the seqcount as a try_acquire then it
should not do this anymore.
Sebastian
next prev parent reply other threads:[~2020-09-08 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:55 [ANNOUNCE] v5.9-rc3-rt3 Sebastian Andrzej Siewior
2020-09-05 4:47 ` v5.9-rc3-rt3 boot time networking lockdep splat Mike Galbraith
2020-09-05 5:19 ` Mike Galbraith
2020-09-08 15:12 ` Sebastian Andrzej Siewior
2020-09-08 15:59 ` Mike Galbraith
2020-09-08 16:02 ` Sebastian Andrzej Siewior
2020-09-08 12:19 ` Sebastian Andrzej Siewior [this message]
2020-09-08 14:56 ` Mike Galbraith
2020-09-08 15:06 ` Sebastian Andrzej Siewior
2020-09-08 16:19 ` Mike Galbraith
2020-09-09 2:39 ` Mike Galbraith
2020-09-09 3:12 ` [ANNOUNCE] v5.9-rc3-rt3 Mike Galbraith
2020-09-09 5:07 ` Mike Galbraith
2020-09-09 5:45 ` Mike Galbraith
2020-09-09 8:20 ` Sebastian Andrzej Siewior
2020-09-09 8:56 ` Mike Galbraith
2020-09-09 8:59 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908121902.zlfd3balosnu7ies@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).