From: Daniel Wagner <dwagner@suse.de> To: Clark Williams <williams@redhat.com>, John Kacur <jkacur@redhat.com> Cc: linux-rt-users@vger.kernel.org, Daniel Wagner <dwagner@suse.de> Subject: [rt-tests v2 07/18] oslat: Use string parser utilies Date: Wed, 7 Oct 2020 10:56:42 +0200 Message-ID: <20201007085653.11961-8-dwagner@suse.de> (raw) In-Reply-To: <20201007085653.11961-1-dwagner@suse.de> Use available parse_time_string() instead locally implemented version. While at it move the mem parser helper to the global utility header. Signed-off-by: Daniel Wagner <dwagner@suse.de> --- src/oslat/oslat.c | 67 ++--------------------------------------------- 1 file changed, 2 insertions(+), 65 deletions(-) diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c index fafbdd694326..9df1a58f640d 100644 --- a/src/oslat/oslat.c +++ b/src/oslat/oslat.c @@ -570,69 +570,6 @@ static int parse_cpu_list(char *cpu_list, cpu_set_t *cpu_set) return n_cores; } -static int parse_runtime(const char *str) -{ - char *endptr; - int v = strtol(str, &endptr, 10); - - if (!*endptr) - return v; - - switch (*endptr) { - case 'd': - case 'D': - /* Days */ - v *= 24; - case 'h': - case 'H': - /* Hours */ - v *= 60; - case 'm': - case 'M': - /* Minutes */ - v *= 60; - case 's': - case 'S': - /* Seconds */ - break; - default: - printf("Unknown runtime suffix: %s\n", endptr); - v = 0; - break; - } - - return v; -} - -static int parse_mem_size(char *str, uint64_t *val) -{ - char *endptr; - int v = strtol(str, &endptr, 10); - - if (!*endptr) - return v; - - switch (*endptr) { - case 'g': - case 'G': - v *= 1024; - case 'm': - case 'M': - v *= 1024; - case 'k': - case 'K': - v *= 1024; - case 'b': - case 'B': - break; - default: - return -1; - } - - *val = v; - - return 0; -} static int workload_select(char *name) { @@ -700,7 +637,7 @@ static void parse_options(int argc, char *argv[]) } break; case 'D': - g.runtime = parse_runtime(optarg); + g.runtime = parse_time_string(optarg); if (!g.runtime) { printf("Illegal runtime: %s\n", optarg); exit(1); @@ -734,7 +671,7 @@ static void parse_options(int argc, char *argv[]) } break; case 'm': - if (parse_mem_size(optarg, &g.workload_mem_size)) { + if (parse_mem_string(optarg, &g.workload_mem_size)) { printf("Unknown workload memory size '%s'.\n\n", optarg); exit(1); } -- 2.28.0
next prev parent reply index Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-07 8:56 [rt-tests v2 00/18] Streamline command line Daniel Wagner 2020-10-07 8:56 ` [rt-tests v2 01/18] rt-util: Move parse_cpumask from cyclictest Daniel Wagner 2020-10-23 15:46 ` John Kacur 2020-10-26 18:34 ` Daniel Wagner 2020-10-29 15:45 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 02/18] cyclictest: Use numa library helpers in get_available_cpus() Daniel Wagner 2020-10-23 15:55 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 03/18] cyclicdeadline: Streamline usage output and man page Daniel Wagner 2020-10-23 16:01 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 04/18] cyclicdeadline: Add long command line options Daniel Wagner 2020-10-23 16:07 ` John Kacur 2020-10-27 8:07 ` Daniel Wagner 2020-10-07 8:56 ` [rt-tests v2 05/18] deadline_test: Streamline usage output and man page Daniel Wagner 2020-10-23 16:10 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 06/18] oslat: " Daniel Wagner 2020-10-23 17:19 ` John Kacur 2020-10-07 8:56 ` Daniel Wagner [this message] 2020-10-23 17:25 ` [rt-tests v2 07/18] oslat: Use string parser utilies John Kacur 2020-10-27 8:09 ` Daniel Wagner 2020-10-07 8:56 ` [rt-tests v2 08/18] pip_stress: Add command line parser Daniel Wagner 2020-10-23 17:33 ` John Kacur 2020-10-27 8:09 ` Daniel Wagner 2020-10-07 8:56 ` [rt-tests v2 09/18] pi_stress: Streamline usage output and man page Daniel Wagner 2020-10-07 8:56 ` [rt-tests v2 10/18] pmqtest: " Daniel Wagner 2020-10-23 18:18 ` John Kacur 2020-10-23 18:23 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 11/18] ptsematest: " Daniel Wagner 2020-10-23 18:25 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 12/18] queuelat: Streamline usage " Daniel Wagner 2020-10-23 18:40 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 13/18] rt-migrate-test: " Daniel Wagner 2020-10-23 18:47 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 14/18] signaltest: " Daniel Wagner 2020-10-23 18:50 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 15/18] sigwaittest: " Daniel Wagner 2020-10-23 18:51 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 16/18] ssdd: " Daniel Wagner 2020-10-23 18:57 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 17/18] svsematest: " Daniel Wagner 2020-10-23 18:59 ` John Kacur 2020-10-07 8:56 ` [rt-tests v2 18/18] hackbench: " Daniel Wagner 2020-10-23 19:03 ` John Kacur
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201007085653.11961-8-dwagner@suse.de \ --to=dwagner@suse.de \ --cc=jkacur@redhat.com \ --cc=linux-rt-users@vger.kernel.org \ --cc=williams@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-rt-users Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \ linux-rt-users@vger.kernel.org public-inbox-index linux-rt-users Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users AGPL code for this site: git clone https://public-inbox.org/public-inbox.git