From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Christian Eggers <ceggers@arri.de>,
tglx@linutronix.de, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sched: system doesn't boot since "sched: Add new migrate_disable() implementation"
Date: Tue, 20 Oct 2020 13:38:28 +0200 [thread overview]
Message-ID: <20201020113828.fv7ui4h3gkrcpqoc@linutronix.de> (raw)
In-Reply-To: <20201020113009.GR2628@hirez.programming.kicks-ass.net>
On 2020-10-20 13:30:09 [+0200], Peter Zijlstra wrote:
> On Mon, Oct 19, 2020 at 05:09:35PM +0200, Sebastian Andrzej Siewior wrote:
> > On 2020-10-19 12:21:06 [+0200], Christian Eggers wrote:
> > > I have problems with the latest 5.9-rt releases on i.MX6ULL (!CONFIG_SMP):
> > >
> > …
> > > Any hints?
> >
> > Thank you for the report. The reason is the migrate_disable()
> > implementation for !SMP.
>
> This should fix things I suppose. I'll fold it in.
It will. It will also break lazy-preemption. Each time a sleeping lock
is acquired there is also migrate_disable() and the migrate-disable
counter is != 0 (even for UP). The result is that a wake up for a
SCHED_OTHER task with mg counter != 0 will not lead to context switch
(same like preemption counter != 0). The difference is that a wake up
for a RT task ignores this counter and perform a context switch anyway.
That way we have RT wake ups on time but avoid stumbling from one lock
to another.
> ---
> --- a/include/linux/preempt.h
> +++ b/include/linux/preempt.h
> @@ -378,7 +378,12 @@ static inline void preempt_notifier_init
> extern void migrate_disable(void);
> extern void migrate_enable(void);
>
> -#else /* !(CONFIG_SMP && CONFIG_PREEMPT_RT) */
> +#elif defined(CONFIG_PREEMPT_RT)
> +
> +static inline void migrate_disable(void) { }
> +static inline void migrate_enable(void { }
> +
> +#else /* !CONFIG_PREEMPT_RT */
>
> /**
> * migrate_disable - Prevent migration of the current task
Sebastian
next prev parent reply other threads:[~2020-10-20 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 10:21 sched: system doesn't boot since "sched: Add new migrate_disable() implementation" Christian Eggers
2020-10-19 15:09 ` Sebastian Andrzej Siewior
2020-10-20 11:30 ` Peter Zijlstra
2020-10-20 11:38 ` Sebastian Andrzej Siewior [this message]
2020-10-20 11:41 ` Peter Zijlstra
2020-10-20 11:51 ` Sebastian Andrzej Siewior
2020-10-20 12:38 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020113828.fv7ui4h3gkrcpqoc@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=ceggers@arri.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).