From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Hillf Danton <hdanton@sina.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: kvm+nouveau induced lockdep gripe
Date: Tue, 27 Oct 2020 10:00:19 +0100 [thread overview]
Message-ID: <20201027090019.3vteojm43ljqqe33@linutronix.de> (raw)
In-Reply-To: <0dfae65db2f0d3ef603c1db34f37cee63f7f41f4.camel@gmx.de>
On 2020-10-27 07:03:38 [+0100], Mike Galbraith wrote:
> On Mon, 2020-10-26 at 20:53 +0100, Sebastian Andrzej Siewior wrote:
> >
> > Could you try this, please?
>
> Nogo, first call of sched_setscheduler() is via kthread_create(). I
> confirmed that nuking that (gratuitous user foot saving override) call
> on top of moving sched_set_fifo() does shut it up, but that won't fly.
mkay. but this then, too. Let me try if I can figure out when this
broke.
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 3edaa380dc7b4..64d6afb127239 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -244,6 +244,7 @@ EXPORT_SYMBOL_GPL(kthread_parkme);
static int kthread(void *_create)
{
/* Copy data: it's on kthread's stack */
+ static const struct sched_param param = { .sched_priority = 0 };
struct kthread_create_info *create = _create;
int (*threadfn)(void *data) = create->threadfn;
void *data = create->data;
@@ -273,6 +274,13 @@ static int kthread(void *_create)
init_completion(&self->parked);
current->vfork_done = &self->exited;
+ /*
+ * root may have changed our (kthreadd's) priority or CPU mask.
+ * The kernel thread should not inherit these properties.
+ */
+ sched_setscheduler_nocheck(current, SCHED_NORMAL, ¶m);
+ set_cpus_allowed_ptr(current, housekeeping_cpumask(HK_FLAG_KTHREAD));
+
/* OK, tell user we're spawned, wait for stop or wakeup */
__set_current_state(TASK_UNINTERRUPTIBLE);
create->result = current;
@@ -370,7 +378,6 @@ struct task_struct *__kthread_create_on_node(int (*threadfn)(void *data),
}
task = create->result;
if (!IS_ERR(task)) {
- static const struct sched_param param = { .sched_priority = 0 };
char name[TASK_COMM_LEN];
/*
@@ -379,13 +386,6 @@ struct task_struct *__kthread_create_on_node(int (*threadfn)(void *data),
*/
vsnprintf(name, sizeof(name), namefmt, args);
set_task_comm(task, name);
- /*
- * root may have changed our (kthreadd's) priority or CPU mask.
- * The kernel thread should not inherit these properties.
- */
- sched_setscheduler_nocheck(task, SCHED_NORMAL, ¶m);
- set_cpus_allowed_ptr(task,
- housekeeping_cpumask(HK_FLAG_KTHREAD));
}
kfree(create);
return task;
Sebastian
next prev parent reply other threads:[~2020-10-27 9:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201021125324.ualpvrxvzyie6d7d@linutronix.de>
2020-10-21 13:14 ` [ANNOUNCE] v5.9.1-rt18 Sebastian Andrzej Siewior
2020-10-27 6:53 ` Fernando Lopez-Lezcano
2020-10-27 8:22 ` Sebastian Andrzej Siewior
2020-10-27 17:07 ` Fernando Lopez-Lezcano
2020-10-28 20:24 ` Sebastian Andrzej Siewior
2020-10-22 5:21 ` ltp or kvm triggerable lockdep alloc_pid() deadlock gripe Mike Galbraith
2020-10-22 16:44 ` Sebastian Andrzej Siewior
2020-10-22 5:28 ` kvm+nouveau induced lockdep gripe Mike Galbraith
2020-10-23 9:01 ` Sebastian Andrzej Siewior
2020-10-23 12:07 ` Mike Galbraith
[not found] ` <20201024022236.19608-1-hdanton@sina.com>
2020-10-24 3:38 ` Mike Galbraith
[not found] ` <20201024050000.8104-1-hdanton@sina.com>
2020-10-24 5:25 ` Mike Galbraith
[not found] ` <20201024094224.2804-1-hdanton@sina.com>
2020-10-26 17:26 ` Sebastian Andrzej Siewior
2020-10-26 17:31 ` Sebastian Andrzej Siewior
2020-10-26 19:15 ` Mike Galbraith
2020-10-26 19:53 ` Sebastian Andrzej Siewior
2020-10-27 6:03 ` Mike Galbraith
2020-10-27 9:00 ` Sebastian Andrzej Siewior [this message]
2020-10-27 9:49 ` Mike Galbraith
2020-10-27 10:14 ` Mike Galbraith
2020-10-27 10:18 ` Sebastian Andrzej Siewior
2020-10-27 11:13 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027090019.3vteojm43ljqqe33@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bskeggs@redhat.com \
--cc=efault@gmx.de \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).