From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A30C4361B for ; Fri, 18 Dec 2020 16:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECD4023B6C for ; Fri, 18 Dec 2020 16:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730022AbgLRQTc (ORCPT ); Fri, 18 Dec 2020 11:19:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:36864 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgLRQTc (ORCPT ); Fri, 18 Dec 2020 11:19:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 956A7ACF1; Fri, 18 Dec 2020 16:18:50 +0000 (UTC) From: Daniel Wagner To: Clark Williams , John Kacur Cc: linux-rt-users@vger.kernel.org, Daniel Wagner Subject: [rt-tests v2 v2 00/20] rt-numa.h cleanups Date: Fri, 18 Dec 2020 17:18:23 +0100 Message-Id: <20201218161843.1764-1-dwagner@suse.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org This series cleans up the rt-numa.h header. As we have a hard dependency on libnuma we can simplify the code in cyclictest. This allows remove all the small helpers in rt_numa.h. And with this we can remove the header and reduce the confusion with rt-numa.h While at it, I simplified the --smp vs --affinity vs --threads logic. There is no need for additional variables to keep state. With this we also make --affinity to behave as with the rest of rt-tests. That is a plan -a will be the same as with -S. There is no need for -S anymore but I think we should leave it in place for backwards compatibility. I suspect, there must be a lot of muscle memory out there :) Since signaltest has the same code as cyclictest, cleanup this tool as well. With all those cleanups in cyclictest and signaltest, rt-numa.h contains only a three functions. The final part of the series is to remove unnecessary function arguments (max_cpus). This also fixes the theoretical problem that a sparse cpumask would not be handled correctly. changes v2: - added more cleanup patches (7-20) Daniel Wagner (20): cyclictest: Always use libnuma cyclictest: Use numa API directly cyclictest: Use affinity_mask for stearing thread placement cyclictest: Mimik --smp behavior with --affinity cyclictest: Simplify --smp vs --affinity vs --threads argument logic cyclictest: Move verbose message into main signaltest: Always use libnuma signaltest: Use affinity_mask for stearing thread placement signaltest: Simplify --smp vs --affinity vs --threads argument logic rt-numa: Remove unused definitions and numa_initialize() rt-numa: Add generic cpu_for_thread() helper rt-numa: Use mask size for iterator limit rt-numa: Remove max_cpus argument from parse_cpusmask rt-numa: Use error message helpers signaltest: Remove unused max_cpus argument from process_options cyclictest: Remove unused max_cpus argument from process_options rt-numa: Use CPU_SETSIZE as upper loop limit rt-numa: Remove used max_cpus argument from cpu_for_thread() cyclictest: Remove max cpus used verbose information cyclictest: Remove unecessary local variable src/cyclictest/cyclictest.c | 177 +++++++++++++----------------------- src/cyclictest/rt_numa.h | 98 -------------------- src/include/rt-numa.h | 13 +-- src/lib/rt-numa.c | 44 ++++----- src/oslat/oslat.c | 3 +- src/signaltest/signaltest.c | 80 ++++------------ 6 files changed, 101 insertions(+), 314 deletions(-) delete mode 100644 src/cyclictest/rt_numa.h -- 2.29.2