From: Daniel Wagner <dwagner@suse.de>
To: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>, linux-rt-users@vger.kernel.org
Subject: Re: [rt-tests v1 4/6] cyclictest: Mimik --smp behavior with --affinity
Date: Tue, 26 Jan 2021 09:37:22 +0100 [thread overview]
Message-ID: <20210126083722.tpyy4jsv25sqzsnk@beryllium.lan> (raw)
In-Reply-To: <f273ca2-e80-7713-7caa-6dff464d388@redhat.com>
On Tue, Jan 26, 2021 at 12:55:33AM -0500, John Kacur wrote:
> Well, --smp historically combined -a -t and threads at the same priority
> You could argue that it is reasonable for -a to automatically imply -t
> but I have had debates with people about this and we settled on -a just
> specifies the affinity, and the default number of threads is one unless
> you use -t.
My thinking is if you set an affinity mask, you want also to assign a
thread to the CPUs. If not what's the point to set an affinity mask
without a thread on it. Though the user is able to overwrite this
by providing the -t options along side the -a option.
> I'm not sure what you mean by this makes cyclictest behave the way the
> rest of rt-tests does, the rest of rt-tests should match what cyclitest
> does.
As I wrote, make cyclictest behave the same way as the to other tools
when -a/-t is used.
> That said, I did some quick runs of signaltest and -a seems broken,
> sigh.
Is it broken without my patches or with my patches? What is broken?
next prev parent reply other threads:[~2021-01-26 8:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:19 [rt-tests v1 0/6] libnuma cleanups for cyclictest Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 1/6] cyclictest: Always use libnuma Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 2/6] cyclictest: Use numa API directly Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 3/6] cyclictest: Use affinity_mask for stearing thread placement Daniel Wagner
2021-01-26 5:39 ` John Kacur
2021-01-26 8:41 ` Daniel Wagner
2021-01-26 16:33 ` John Kacur
2021-01-26 17:13 ` Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 4/6] cyclictest: Mimik --smp behavior with --affinity Daniel Wagner
2021-01-26 5:55 ` John Kacur
2021-01-26 8:37 ` Daniel Wagner [this message]
2021-01-26 16:32 ` John Kacur
2021-01-26 17:13 ` Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 5/6] cyclictest: Simplify --smp vs --affinity vs --threads argument logic Daniel Wagner
2020-12-18 14:19 ` [rt-tests v1 6/6] cyclictest: Move verbose message into main Daniel Wagner
2020-12-18 14:41 ` [rt-tests v1 0/6] libnuma cleanups for cyclictest Daniel Wagner
2020-12-18 16:02 ` John Kacur
2020-12-18 16:43 ` Daniel Wagner
2020-12-18 15:57 ` John Kacur
2020-12-18 16:41 ` Daniel Wagner
2020-12-22 17:26 ` Alison Chaiken
2020-12-22 18:04 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126083722.tpyy4jsv25sqzsnk@beryllium.lan \
--to=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).