From: Peter Xu <peterx@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: John Kacur <jkacur@redhat.com>,
Clark Williams <williams@redhat.com>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH rt-tests 1/2] oslat: Print version string
Date: Wed, 10 Feb 2021 14:26:03 -0500 [thread overview]
Message-ID: <20210210192603.GT103365@xz-x1> (raw)
In-Reply-To: <20210210181504.z6ckihv5zghexrne@beryllium.lan>
On Wed, Feb 10, 2021 at 07:15:04PM +0100, Daniel Wagner wrote:
> > It's great idea to have JSON format for all the tools. However I just don't
> > see why "-v"/"--version" is related to your machine readable output work.
> > Could you exlaborate? Thanks,
>
> I've added long options support to many rt-tests in the mentioned
> series. I would like to base this fix on top of this work.
My opinion probably don't even matter here... but I tend to agree with John
that the fix and your work is separated. If there's must a rebase, it would be
better to rebase the big series upon the fix rather than the other way round,
simply because a fix is normally more important than a new feature (if not
talking about this "-v" thing, the other --cpu-list issue should be important).
Appreciate all the refactoring works on oslat happened and ongoing, it would
just be even nicer if the touched code path can be smoked so we don't miss
anything important.
Thanks again.
--
Peter Xu
next prev parent reply other threads:[~2021-02-10 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 16:54 [PATCH rt-tests 0/2] oslat fixes Daniel Wagner
2021-02-10 16:54 ` [PATCH rt-tests 1/2] oslat: Print version string Daniel Wagner
2021-02-10 17:12 ` Peter Xu
2021-02-10 17:28 ` John Kacur
2021-02-10 17:33 ` Daniel Wagner
2021-02-10 17:53 ` Peter Xu
2021-02-10 18:15 ` Daniel Wagner
2021-02-10 19:26 ` Peter Xu [this message]
2021-02-10 17:59 ` John Kacur
2021-02-10 18:21 ` Daniel Wagner
2021-02-10 19:12 ` John Kacur
2021-02-11 4:32 ` John Kacur
2021-02-10 16:54 ` [PATCH rt-tests 2/2] oslat: Use cpuset size as upper bound Daniel Wagner
2021-02-10 17:14 ` Peter Xu
2021-02-11 4:28 ` John Kacur
2021-02-11 15:24 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210192603.GT103365@xz-x1 \
--to=peterx@redhat.com \
--cc=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).