From: Jonathan Schwender <schwenderjonathan@gmail.com>
To: jkacur@redhat.com, williams@redhat.com
Cc: linux-rt-users@vger.kernel.org
Subject: [PATCH 1/2] cyclictest: Move main pid setaffinity handling into a function
Date: Mon, 22 Feb 2021 16:28:32 +0100 [thread overview]
Message-ID: <20210222152833.8758-3-schwenderjonathan@gmail.com> (raw)
In-Reply-To: <20210222152833.8758-1-schwenderjonathan@gmail.com>
Move error handling for setting the affinity of the main pid
into a separate function.
This prevents duplicating the code in the next commit,
where the main thread pid can be restricted to one of
two bitmasks depending on the passed parameters.
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
---
src/cyclictest/cyclictest.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index c3d45f3..3cd592d 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -1749,6 +1749,16 @@ static void write_stats(FILE *f, void *data)
fprintf(f, " }\n");
}
+static void set_main_thread_affinity(struct bitmask* cpumask) {
+ int res;
+
+ errno = 0;
+ res = numa_sched_setaffinity(getpid(), cpumask);
+ if (res != 0)
+ warn("Couldn't setaffinity in main thread: %s\n", strerror(errno));
+}
+
+
int main(int argc, char **argv)
{
sigset_t sigset;
@@ -1778,13 +1788,7 @@ int main(int argc, char **argv)
/* Restrict the main pid to the affinity specified by the user */
if (affinity_mask) {
- int res;
-
- errno = 0;
- res = numa_sched_setaffinity(getpid(), affinity_mask);
- if (res != 0)
- warn("Couldn't setaffinity in main thread: %s\n", strerror(errno));
-
+ set_main_thread_affinity(affinity_mask);
if (verbose)
printf("Using %u cpus.\n",
numa_bitmask_weight(affinity_mask));
--
2.29.2
next prev parent reply other threads:[~2021-02-22 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 15:28 rt-tests: cyclictest: Add option to specify main pid affinity Jonathan Schwender
2021-02-22 15:28 ` [PATCH 0/2] " Jonathan Schwender
2021-02-22 15:28 ` Jonathan Schwender [this message]
2021-02-23 5:12 ` [PATCH 1/2] cyclictest: Move main pid setaffinity handling into a function John Kacur
2021-02-22 15:28 ` [PATCH 2/2] cyclictest: Add --mainaffinity=[CPUSET] option Jonathan Schwender
2021-02-22 16:20 ` rt-tests: cyclictest: Add option to specify main pid affinity Ahmed S. Darwish
2021-02-22 17:05 ` Jonathan Schwender
2021-03-21 17:11 ` Jonathan Schwender
2021-03-23 16:51 ` John Kacur
2021-03-24 9:32 ` Ahmed S. Darwish
2021-03-29 14:37 ` Jonathan Schwender
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222152833.8758-3-schwenderjonathan@gmail.com \
--to=schwenderjonathan@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).