linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ran Wang <ran.wang_1@nxp.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jiafei Pan <jiafei.pan@nxp.com>,
	"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Sebastian Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] rt: cpufreq: Fix cpu hotplug hang
Date: Tue, 23 Feb 2021 08:43:08 +0530	[thread overview]
Message-ID: <20210223031308.rjwswy5whejrme43@vireshk-i7> (raw)
In-Reply-To: <AM6PR04MB5413DB3654A87D50C909004CF1809@AM6PR04MB5413.eurprd04.prod.outlook.com>

On 23-02-21, 02:26, Ran Wang wrote:
> On Monday, February 22, 2021 10:01 PM, Sebastian Siewior wrote:
> > On 2021-02-19 16:44:20 [+0800], Ran Wang wrote:
> > > When selecting PREEMPT_RT, cpufreq_driver->stop_cpu(policy) might got
> > > stuck due to irq_work_sync() pending for work on lazy_list. That’s
> > > because lazy_list may have no chance to be served in softirq context
> > > sometimes. Below is one of scenarios that was captured:
> > >
> > > ...
> > > ret_from_fork
> > >  kthread
> > >   smpboot_thread_fn
> > >    cpuhp_thread_fun
> > >     cpuhp_invoke_callback: state: 193
> > >      cpuhp_cpufreq_online
> > >       cpufreq_online
> > >        cpufreq_driver->stop_cpu(policy);
> > >         cpufreq_dbs_governor_stop
> > >          sugov_stop  // kernel/sched/cpufreq_schedutil.c
> > >           irq_work_sync(&sg_policy->irq_work);
> > >
> > > This is observed on LX2160ARDB (16 A72 cores) with cpufreq governor of
> > > ‘schedutil’ or ‘ondemand’.
> > 
> > While staring at it, why do we invoke schedule_work_on() and
> > kthread_queue_work() from inside irq_work() instead invoking it directly? It raises an interrupt in which it kicks a user thread.
> > Couldn't we do it without irq_work?

Because we reach there from scheduler's context, which must be
hard-irq context..

-- 
viresh

  reply	other threads:[~2021-02-23  3:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  8:44 [PATCH] rt: cpufreq: Fix cpu hotplug hang Ran Wang
2021-02-22 14:01 ` Sebastian Siewior
2021-02-23  2:26   ` Ran Wang
2021-02-23  3:13     ` Viresh Kumar [this message]
2021-02-24 16:37       ` Sebastian Siewior
2021-02-25  2:31         ` Ran Wang
2021-03-23  7:00         ` Ran Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223031308.rjwswy5whejrme43@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=bigeasy@linutronix.de \
    --cc=jiafei.pan@nxp.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ran.wang_1@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).