linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: RT <linux-rt-users@vger.kernel.org>
Cc: John Kacur <jkacur@redhat.com>
Subject: [PATCH] rt-tests: cyclicdeadline.c: Remove dead code
Date: Wed,  3 Mar 2021 16:09:42 -0500	[thread overview]
Message-ID: <20210303210942.15847-1-jkacur@redhat.com> (raw)

In cyclicdeadline there is some unreachable code that was there from the
beginning. By inspection it looks like this change was the original
intention.

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/sched_deadline/cyclicdeadline.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index ed3c960d9916..33bac8cda898 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -560,13 +560,11 @@ static void destroy_cpuset(const char *name, int print)
 	sleep(1);
 	ret = rmdir(path);
 	if (ret < 0) {
-		if (retry++ < 5)
-			goto again;
-		err_msg_n(errno, "Failed to remove %s\n", path);
 		if (retry++ < 5) {
 			err_msg("Trying again\n");
 			goto again;
 		}
+		err_msg_n(errno, "Failed to remove %s\n", path);
 	}
 }
 
-- 
2.26.2


                 reply	other threads:[~2021-03-04  0:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303210942.15847-1-jkacur@redhat.com \
    --to=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).