From: Daniel Wagner <dwagner@suse.de>
To: Clark Williams <williams@redhat.com>, John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH rt-tests v2 11/14] pi_stress: Prepare command line parser for long options only
Date: Fri, 5 Mar 2021 08:34:57 +0100 [thread overview]
Message-ID: <20210305073500.17926-12-dwagner@suse.de> (raw)
In-Reply-To: <20210305073500.17926-1-dwagner@suse.de>
Introduce option value enums in order to be able to parse long options
only.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
src/pi_tests/pi_stress.c | 45 ++++++++++++++++++++++++++++------------
1 file changed, 32 insertions(+), 13 deletions(-)
diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
index 49f89b7b0136..73f0e6a402e3 100644
--- a/src/pi_tests/pi_stress.c
+++ b/src/pi_tests/pi_stress.c
@@ -1274,23 +1274,29 @@ int process_sched_line(const char *arg)
return retval;
}
+enum option_values {
+ OPT_DEBUG=1, OPT_DURATION, OPT_GROUPS, OPT_HELP, OPT_INVERSIONS,
+ OPT_MLOCKALL, OPT_PROMPT, OPT_QUIET, OPT_RR, OPT_SCHED,
+ OPT_UNIPROCESSOR, OPT_VERBOSE, OPT_VERSION,
+};
+
void process_command_line(int argc, char **argv)
{
for (;;) {
struct option options[] = {
- {"debug", no_argument, NULL, 'd'},
- {"duration", required_argument, NULL, 'D'},
- {"groups", required_argument, NULL, 'g'},
- {"help", no_argument, NULL, 'h'},
- {"inversions", required_argument, NULL, 'i'},
- {"mlockall", no_argument, NULL, 'm'},
- {"prompt", no_argument, NULL, 'p'},
- {"quiet", no_argument, NULL, 'q'},
- {"rr", no_argument, NULL, 'r'},
- {"sched", required_argument, NULL, 's'},
- {"uniprocessor", no_argument, NULL, 'u'},
- {"verbose", no_argument, NULL, 'v'},
- {"version", no_argument, NULL, 'V'},
+ {"debug", no_argument, NULL, OPT_DEBUG},
+ {"duration", required_argument, NULL, OPT_DURATION},
+ {"groups", required_argument, NULL, OPT_GROUPS},
+ {"help", no_argument, NULL, OPT_HELP},
+ {"inversions", required_argument, NULL, OPT_INVERSIONS},
+ {"mlockall", no_argument, NULL, OPT_MLOCKALL},
+ {"prompt", no_argument, NULL, OPT_PROMPT},
+ {"quiet", no_argument, NULL, OPT_QUIET},
+ {"rr", no_argument, NULL, OPT_RR},
+ {"sched", required_argument, NULL, OPT_SCHED},
+ {"uniprocessor", no_argument, NULL, OPT_UNIPROCESSOR},
+ {"verbose", no_argument, NULL, OPT_VERBOSE},
+ {"version", no_argument, NULL, OPT_VERSION},
{NULL, 0, NULL, 0},
};
@@ -1298,12 +1304,15 @@ void process_command_line(int argc, char **argv)
if (c == -1)
break;
switch (c) {
+ case OPT_DEBUG:
case 'd':
debugging = 1;
break;
+ case OPT_DURATION:
case 'D':
duration = parse_time_string(optarg);
break;
+ case OPT_GROUPS:
case 'g':
ngroups = strtol(optarg, NULL, 10);
if (ngroups > num_processors) {
@@ -1314,37 +1323,47 @@ void process_command_line(int argc, char **argv)
}
pi_info("number of groups set to %d\n", ngroups);
break;
+ case OPT_HELP:
case 'h':
usage(0);
break;
+ case OPT_INVERSIONS:
case 'i':
inversions = strtol(optarg, NULL, 10);
pi_info("doing %d inversion per group\n", inversions);
break;
+ case OPT_MLOCKALL:
case 'm':
lockall = 1;
break;
+ case OPT_PROMPT:
case 'p':
prompt = 1;
break;
+ case OPT_QUIET:
case 'q':
verbose = 0;
quiet = 1;
break;
+ case OPT_RR:
case 'r':
policy = SCHED_RR;
break;
+ case OPT_SCHED:
case 's':
if (process_sched_line(optarg))
pi_error("ignoring invalid options '%s'\n", optarg);
break;
+ case OPT_UNIPROCESSOR:
case 'u':
uniprocessor = 1;
break;
+ case OPT_VERBOSE:
case 'v':
verbose = 1;
quiet = 0;
break;
+ case OPT_VERSION:
case 'V':
printf("pi_stress v%1.2f ", VERSION);
exit(0);
--
2.30.1
next prev parent reply other threads:[~2021-03-05 7:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 7:34 [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 01/14] cyclictest: Fix printf format specifier Daniel Wagner
2021-03-14 22:45 ` John Kacur
2021-03-15 8:57 ` Daniel Wagner
2021-03-15 8:58 ` Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 02/14] cyclicdeadline.c: " Daniel Wagner
2021-03-14 22:45 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 03/14] signaltest: Add missing --output usage info Daniel Wagner
2021-03-14 22:47 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 04/14] rt-util: Copy command line before getopt_long() is called Daniel Wagner
2021-03-15 5:47 ` John Kacur
2021-03-15 8:56 ` Daniel Wagner
2021-03-15 14:41 ` John Kacur
2021-03-05 7:34 ` [PATCH rt-tests v2 05/14] rt-util: Add start time of test execution for JSON output Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 06/14] rt-util: Add return_code to common section of " Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 07/14] pip_stress: Move test result output to main Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 08/14] pip_stress: Return failure code if test fails Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 09/14] pip_stress: Prepare arg parser to accept only long options Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 10/14] pip_stress: Add JSON output feature Daniel Wagner
2021-03-05 7:34 ` Daniel Wagner [this message]
2021-03-05 7:34 ` [PATCH rt-tests v2 12/14] pi_stress: " Daniel Wagner
2021-03-05 7:34 ` [PATCH rt-tests v2 13/14] ssdd: Add quiet command line option Daniel Wagner
2021-03-05 7:35 ` [PATCH rt-tests v2 14/14] ssdd: Add JSON output feature Daniel Wagner
2021-03-05 7:41 ` [PATCH rt-tests v2 00/14] JSON cleanups and more tests updated Daniel Wagner
2021-03-05 15:29 ` John Kacur
2021-03-05 15:41 ` Daniel Wagner
2021-03-05 15:51 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305073500.17926-12-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).