linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: punit1.agrawal@toshiba.co.jp, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 3/5] rteval: kernel.py: Add support for kthreads running with deadline policy
Date: Wed, 15 Sep 2021 08:17:08 -0400 (EDT)	[thread overview]
Message-ID: <3382122d-6381-c664-af6e-461f7b992be@redhat.com> (raw)
In-Reply-To: <87v9326xd5.fsf@stealth>



On Wed, 15 Sep 2021, Punit Agrawal wrote:

> Hi John,
> 
> John Kacur <jkacur@redhat.com> writes:
> 
> > On Wed, 1 Sep 2021, Punit Agrawal wrote:
> >
> >> From: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> >> 
> >> When running rteval on a system with kthreads running with "deadline"
> >> policy, an exception is encountered when parsing the output of "ps".
> >> 
> >>     [DEBUG] cmd: /usr/bin/ps -eocommand,pid,policy,rtprio,comm
> >>     Traceback (most recent call last):
> >>     ...
> >>       File "...rteval/rteval/sysinfo/kernel.py", line 60, in kernel_get_kthreads
> >> 	ret_kthreads[v[0]] = {'policy' : policies[bytes.decode(v[1])],
> >>       KeyError: 'DLN'
> >> 
> >> The kernel uses deadline policy for "schedutil" cpufreq governor
> >> threads. Fix the crash in rteval by adding support for "deadline" to
> >> the list of policies.
> >> 
> >> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> >> ---
> >>  rteval/sysinfo/kernel.py | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/rteval/sysinfo/kernel.py b/rteval/sysinfo/kernel.py
> >> index 97ad9402b13e..f2e9d72ac2ef 100644
> >> --- a/rteval/sysinfo/kernel.py
> >> +++ b/rteval/sysinfo/kernel.py
> >> @@ -44,7 +44,7 @@ class KernelInfo:
> >>  
> >>  
> >>      def kernel_get_kthreads(self):
> >> -        policies = {'FF':'fifo', 'RR':'rrobin', 'TS':'other', '?':'unknown'}
> >> +        policies = {'DLN': 'deadline', 'FF':'fifo', 'RR':'rrobin', 'TS':'other', '?':'unknown'}
> >>          ret_kthreads = {}
> >>          self.__log(Log.DEBUG, "getting kthread status")
> >>          cmd = '%s -eocommand,pid,policy,rtprio,comm' % getcmdpath('ps')
> >> -- 
> >> 2.32.0
> >> 
> >> 
> >
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> 
> It looks like this patch and the other one converting hackbench memory
> check to a warning was missed when applying the rest of the series -
> John, could you please pick these as well.
> 
> Thanks,
> Punit
> 

I added the patch to support deadline policy, the other one had already 
been added, I just hadn't pushed upstream yet, but I just did so, so go 
ahead and pull.

John


  reply	other threads:[~2021-09-15 12:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  8:08 [PATCH 0/5] Enable rteval on Arm based systems Punit Agrawal
2021-09-01  8:08 ` [PATCH 1/5] rteval: systopology.py: Add support for systems that don't have Numa Punit Agrawal
2021-09-09 12:34   ` John Kacur
2021-09-13  2:28     ` Punit Agrawal
2021-09-01  8:08 ` [PATCH 2/5] rteval: cyclictest.py: Update logic to get core description Punit Agrawal
2021-09-09 12:41   ` John Kacur
2021-09-01  8:08 ` [PATCH 3/5] rteval: kernel.py: Add support for kthreads running with deadline policy Punit Agrawal
2021-09-09 12:47   ` John Kacur
2021-09-15  8:45     ` Punit Agrawal
2021-09-15 12:17       ` John Kacur [this message]
2021-09-16 11:34         ` Punit Agrawal
2021-09-01  8:08 ` [PATCH 4/5] rteval: hackbench.py: Enable running on a system with low memory Punit Agrawal
2021-09-09 12:46   ` John Kacur
2021-09-13  7:18     ` Punit Agrawal
2021-09-13 12:52       ` John Kacur
2021-09-14 18:32   ` John Kacur
2021-09-15  1:54     ` Punit Agrawal
2021-09-01  8:08 ` [PATCH 5/5] rteval: kcompile.py: Gracefully handle missing affinity information Punit Agrawal
2021-09-09 19:23   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3382122d-6381-c664-af6e-461f7b992be@redhat.com \
    --to=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=punit1.agrawal@toshiba.co.jp \
    --cc=punitagrawal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).