From: John Kacur <jkacur@redhat.com>
To: Anubhav Shelat <ashelat@redhat.com>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2 06/10] rteval: Use f-strings in osinfo
Date: Mon, 12 Jun 2023 14:50:40 -0400 (EDT) [thread overview]
Message-ID: <38c31f4-2c24-e437-f763-4b1b3c51f74d@redhat.com> (raw)
In-Reply-To: <20230601202734.813515-7-ashelat@redhat.com>
On Thu, 1 Jun 2023, Anubhav Shelat wrote:
> Use f-strings in osinfo.py
>
> Signed-off-by: Anubhav Shelat <ashelat@redhat.com>
> ---
> rteval/sysinfo/osinfo.py | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/rteval/sysinfo/osinfo.py b/rteval/sysinfo/osinfo.py
> index ead5e3939cfa..83dc78b96fdd 100644
> --- a/rteval/sysinfo/osinfo.py
> +++ b/rteval/sysinfo/osinfo.py
> @@ -55,9 +55,9 @@ class OSInfo:
> shutil.copyfile(dpath, os.path.join(repdir, "dmesg"))
> return
> if os.path.exists('/usr/bin/dmesg'):
> - subprocess.call('/usr/bin/dmesg > %s' % os.path.join(repdir, "dmesg"), shell=True)
> + subprocess.call(f'/usr/bin/dmesg > {os.path.join(repdir, "dmesg")}', shell=True)
> return
> - print("dmesg file not found at %s and no dmesg exe found!" % dpath)
> + print(f"dmesg file not found at {dpath} and no dmesg exe found!")
>
>
>
> @@ -69,16 +69,16 @@ class OSInfo:
> else:
> raise RuntimeError("Can't find sosreport/sysreport")
>
> - self.__logger.log(Log.DEBUG, "report tool: %s" % exe)
> + self.__logger.log(Log.DEBUG, f"report tool: {exe}")
> options = ['-k', 'rpm.rpmva=off',
> '--name=rteval',
> '--batch']
>
> self.__logger.log(Log.INFO, "Generating SOS report")
> - self.__logger.log(Log.INFO, "using command %s" % " ".join([exe]+options))
> + self.__logger.log(Log.INFO, f"using command {' '.join([exe]+options)}")
> subprocess.call([exe] + options)
> for s in glob('/tmp/s?sreport-rteval-*'):
> - self.__logger.log(Log.DEBUG, "moving %s to %s" % (s, repdir))
> + self.__logger.log(Log.DEBUG, f"moving {s} to {repdir}")
> shutil.move(s, repdir)
>
>
> @@ -118,7 +118,7 @@ def unit_test(rootdir):
> log = Log()
> log.SetLogVerbosity(Log.DEBUG|Log.INFO)
> osi = OSInfo(logger=log)
> - print("Base OS: %s" % osi.get_base_os())
> + print(f"Base OS: {osi.get_base_os()}")
>
> print("Testing OSInfo::copy_dmesg('/tmp'): ", end=' ')
> osi.copy_dmesg('/tmp')
> --
> 2.31.1
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
next prev parent reply other threads:[~2023-06-12 18:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 20:27 [PATCH v2 00/10] Cover Letter Anubhav Shelat
2023-06-01 20:27 ` [PATCH v2 01/10] rteval: Use f-strings in rtevalclient.py Anubhav Shelat
2023-06-05 19:28 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 02/10] rteval: Use f-strings in rtevalConfig Anubhav Shelat
2023-06-05 19:31 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 03/10] rteval: Use f-strings in cputopology Anubhav Shelat
2023-06-12 18:32 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 04/10] rteval: Use f-strings in kernel.py Anubhav Shelat
2023-06-12 18:35 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 05/10] rteval: Use f-strings in memory.py Anubhav Shelat
2023-06-12 18:39 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 06/10] rteval: Use f-strings in osinfo Anubhav Shelat
2023-06-12 18:50 ` John Kacur [this message]
2023-06-01 20:27 ` [PATCH v2 07/10] rteval: Use f-strings in services.py Anubhav Shelat
2023-06-12 18:58 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 08/10] rteval: Use f-strings in tools.py Anubhav Shelat
2023-06-12 18:59 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 09/10] Added code to check if the proc/net/if_inet6 file exists while loading IPv6 addresses in the IPv6Addresses class Anubhav Shelat
2023-06-06 15:22 ` John Kacur
2023-06-01 20:27 ` [PATCH v2 10/10] rteval: Use f-strings in __init__.py Anubhav Shelat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c31f4-2c24-e437-f763-4b1b3c51f74d@redhat.com \
--to=jkacur@redhat.com \
--cc=ashelat@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).