Linux-rt-users Archive on lore.kernel.org
 help / color / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Clark Williams <williams@redhat.com>, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH rt-tests v3 30/33] pi_stress: Prepare command line parser for long options only
Date: Fri, 7 May 2021 12:58:38 -0400 (EDT)
Message-ID: <3b256f9b-2b62-f56-914e-c8d894271a61@redhat.com> (raw)
In-Reply-To: <20210320183829.1318-31-dwagner@suse.de>



On Sat, 20 Mar 2021, Daniel Wagner wrote:

> Introduce option value enums in order to be able to parse long options
> only.
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  src/pi_tests/pi_stress.c | 45 ++++++++++++++++++++++++++++------------
>  1 file changed, 32 insertions(+), 13 deletions(-)
> 
> diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
> index 49f89b7b0136..73f0e6a402e3 100644
> --- a/src/pi_tests/pi_stress.c
> +++ b/src/pi_tests/pi_stress.c
> @@ -1274,23 +1274,29 @@ int process_sched_line(const char *arg)
>  	return retval;
>  }
>  
> +enum option_values {
> +	OPT_DEBUG=1, OPT_DURATION, OPT_GROUPS, OPT_HELP, OPT_INVERSIONS,
> +	OPT_MLOCKALL, OPT_PROMPT, OPT_QUIET, OPT_RR, OPT_SCHED,
> +	OPT_UNIPROCESSOR, OPT_VERBOSE, OPT_VERSION,
> +};
> +
>  void process_command_line(int argc, char **argv)
>  {
>  	for (;;) {
>  		struct option options[] = {
> -			{"debug",		no_argument,		NULL, 'd'},
> -			{"duration",		required_argument,	NULL, 'D'},
> -			{"groups",		required_argument,	NULL, 'g'},
> -			{"help",		no_argument,		NULL, 'h'},
> -			{"inversions",		required_argument,	NULL, 'i'},
> -			{"mlockall",		no_argument,		NULL, 'm'},
> -			{"prompt",		no_argument,		NULL, 'p'},
> -			{"quiet",		no_argument,		NULL, 'q'},
> -			{"rr",			no_argument,		NULL, 'r'},
> -			{"sched",		required_argument,	NULL, 's'},
> -			{"uniprocessor",	no_argument,		NULL, 'u'},
> -			{"verbose",		no_argument,		NULL, 'v'},
> -			{"version",		no_argument,		NULL, 'V'},
> +			{"debug",		no_argument,		NULL, OPT_DEBUG},
> +			{"duration",		required_argument,	NULL, OPT_DURATION},
> +			{"groups",		required_argument,	NULL, OPT_GROUPS},
> +			{"help",		no_argument,		NULL, OPT_HELP},
> +			{"inversions",		required_argument,	NULL, OPT_INVERSIONS},
> +			{"mlockall",		no_argument,		NULL, OPT_MLOCKALL},
> +			{"prompt",		no_argument,		NULL, OPT_PROMPT},
> +			{"quiet",		no_argument,		NULL, OPT_QUIET},
> +			{"rr",			no_argument,		NULL, OPT_RR},
> +			{"sched",		required_argument,	NULL, OPT_SCHED},
> +			{"uniprocessor",	no_argument,		NULL, OPT_UNIPROCESSOR},
> +			{"verbose",		no_argument,		NULL, OPT_VERBOSE},
> +			{"version",		no_argument,		NULL, OPT_VERSION},
>  			{NULL, 0, NULL, 0},
>  		};
>  
> @@ -1298,12 +1304,15 @@ void process_command_line(int argc, char **argv)
>  		if (c == -1)
>  			break;
>  		switch (c) {
> +		case OPT_DEBUG:
>  		case 'd':
>  			debugging = 1;
>  			break;
> +		case OPT_DURATION:
>  		case 'D':
>  			duration = parse_time_string(optarg);
>  			break;
> +		case OPT_GROUPS:
>  		case 'g':
>  			ngroups = strtol(optarg, NULL, 10);
>  			if (ngroups > num_processors) {
> @@ -1314,37 +1323,47 @@ void process_command_line(int argc, char **argv)
>  			}
>  			pi_info("number of groups set to %d\n", ngroups);
>  			break;
> +		case OPT_HELP:
>  		case 'h':
>  			usage(0);
>  			break;
> +		case OPT_INVERSIONS:
>  		case 'i':
>  			inversions = strtol(optarg, NULL, 10);
>  			pi_info("doing %d inversion per group\n", inversions);
>  			break;
> +		case OPT_MLOCKALL:
>  		case 'm':
>  			lockall = 1;
>  			break;
> +		case OPT_PROMPT:
>  		case 'p':
>  			prompt = 1;
>  			break;
> +		case OPT_QUIET:
>  		case 'q':
>  			verbose = 0;
>  			quiet = 1;
>  			break;
> +		case OPT_RR:
>  		case 'r':
>  			policy = SCHED_RR;
>  			break;
> +		case OPT_SCHED:
>  		case 's':
>  			if (process_sched_line(optarg))
>  				pi_error("ignoring invalid options '%s'\n", optarg);
>  			break;
> +		case OPT_UNIPROCESSOR:
>  		case 'u':
>  			uniprocessor = 1;
>  			break;
> +		case OPT_VERBOSE:
>  		case 'v':
>  			verbose = 1;
>  			quiet = 0;
>  			break;
> +		case OPT_VERSION:
>  		case 'V':
>  			printf("pi_stress v%1.2f ", VERSION);
>  			exit(0);
> -- 
> 2.30.2
> 
> 
Signed-off-by: John Kacur <jkacur@redhat.com>

  reply index

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 18:37 [PATCH rt-tests v3 00/33] JSON cleanups and more tests updated Daniel Wagner
2021-03-20 18:37 ` [PATCH rt-tests v3 01/33] cyclictest: Remove unused include header Daniel Wagner
2021-05-07 16:17   ` John Kacur
2021-03-20 18:37 ` [PATCH rt-tests v3 02/33] cyclicdeadline: " Daniel Wagner
2021-05-07 16:19   ` John Kacur
2021-03-20 18:37 ` [PATCH rt-tests v3 03/33] signaltest: Add missing --output usage info Daniel Wagner
2021-05-07 16:26   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 04/33] rt-util: Add rt_init function Daniel Wagner
2021-05-07 16:27   ` John Kacur
2021-05-12  7:30     ` Daniel Wagner
2021-03-20 18:38 ` [PATCH rt-tests v3 05/33] cyclictest: Initialize rt-util Daniel Wagner
2021-05-07 16:28   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 06/33] oslat: " Daniel Wagner
2021-05-07 16:29   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 07/33] pmqtest: " Daniel Wagner
2021-05-07 16:29   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 08/33] ptsematest: " Daniel Wagner
2021-05-07 16:30   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 09/33] rt-migrate-test: " Daniel Wagner
2021-05-07 16:31   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 10/33] cyclicdeadline: " Daniel Wagner
2021-05-07 16:31   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 11/33] signaltest: " Daniel Wagner
2021-05-07 16:32   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 12/33] sigwaittest: " Daniel Wagner
2021-05-07 16:33   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 13/33] svematest: " Daniel Wagner
2021-05-07 16:34   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 14/33] rt-util: Remove superfluous arguments from rt_write_json Daniel Wagner
2021-05-07 16:36   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 15/33] rt-util: Introduce rt_test_start() Daniel Wagner
2021-05-07 16:40   ` John Kacur
2021-05-12  7:33     ` Daniel Wagner
2021-03-20 18:38 ` [PATCH rt-tests v3 16/33] cyclictest: Record start of test execution Daniel Wagner
2021-05-07 16:41   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 17/33] oslat: " Daniel Wagner
2021-05-07 16:41   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 18/33] pmqtest: " Daniel Wagner
2021-05-07 16:43   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 19/33] ptesematest: " Daniel Wagner
2021-05-07 16:43   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 20/33] rt-migrate-test: " Daniel Wagner
2021-05-07 16:44   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 21/33] cyclicdeadline: " Daniel Wagner
2021-05-07 16:45   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 22/33] signaltest: " Daniel Wagner
2021-05-07 16:45   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 23/33] sigwaittest: " Daniel Wagner
2021-05-07 16:46   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 24/33] svsematest: " Daniel Wagner
2021-05-07 16:46   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 25/33] rt-util: Add return_code to common section of JSON output Daniel Wagner
2021-05-07 16:49   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 26/33] pip_stress: Move test result output to main Daniel Wagner
2021-05-07 16:55   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 27/33] pip_stress: Return failure code if test fails Daniel Wagner
2021-05-07 16:54   ` John Kacur
2021-05-12  7:35     ` Daniel Wagner
2021-05-13 19:27       ` John Kacur
2021-05-14  6:58         ` Daniel Wagner
2021-03-20 18:38 ` [PATCH rt-tests v3 28/33] pip_stress: Prepare arg parser to accept only long options Daniel Wagner
2021-05-07 16:55   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 29/33] pip_stress: Add JSON output feature Daniel Wagner
2021-05-07 16:58   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 30/33] pi_stress: Prepare command line parser for long options only Daniel Wagner
2021-05-07 16:58   ` John Kacur [this message]
2021-03-20 18:38 ` [PATCH rt-tests v3 31/33] pi_stress: Add JSON output feature Daniel Wagner
2021-05-07 16:59   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 32/33] ssdd: Add quiet command line option Daniel Wagner
2021-05-07 17:00   ` John Kacur
2021-03-20 18:38 ` [PATCH rt-tests v3 33/33] ssdd: Add JSON output feature Daniel Wagner
2021-05-07 17:00   ` John Kacur
2021-03-22 15:50 ` [PATCH rt-tests v3 00/33] JSON cleanups and more tests updated John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b256f9b-2b62-f56-914e-c8d894271a61@redhat.com \
    --to=jkacur@redhat.com \
    --cc=dwagner@suse.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-rt-users Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git