From: John Kacur <jkacur@redhat.com>
To: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
Cc: dwagner@suse.de, "Ahmed S . Darwish" <a.darwish@linutronix.de>,
linux-rt-users@vger.kernel.org, binh1.tranhai@toshiba.co.jp,
Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
Subject: Re: [rteval PATCH 2/2] rteval: cyclictest.py: Make build targets architecture independent
Date: Mon, 22 Feb 2021 15:18:56 -0500 (EST) [thread overview]
Message-ID: <42e6355c-a8c-8529-43d5-d3cb1fc1bfbd@redhat.com> (raw)
In-Reply-To: <20210126021241.112944-3-punit1.agrawal@toshiba.co.jp>
On Tue, 26 Jan 2021, Punit Agrawal wrote:
> Not all kernel archiectures provide the "bzImage" target, e.g., arm64
> provides "Image" which generates an uncompressed kernel binary.
>
> Instead of going down the path of customizing build targets
> per-architecture, let's drop them altogether. The default kernel
> target should build the kernel and modules on all architectures
> anyways.
>
> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> ---
> rteval/modules/loads/kcompile.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rteval/modules/loads/kcompile.py b/rteval/modules/loads/kcompile.py
> index 326f1ae..e747b9f 100644
> --- a/rteval/modules/loads/kcompile.py
> +++ b/rteval/modules/loads/kcompile.py
> @@ -58,7 +58,7 @@ class KBuildJob:
> else:
> self.jobs = self.calc_jobs_per_cpu() * len(self.node)
> self.log(Log.DEBUG, "node %d: jobs == %d" % (int(node), self.jobs))
> - self.runcmd = "%s make O=%s -C %s -j%d bzImage modules" \
> + self.runcmd = "%s make O=%s -C %s -j%d" \
> % (self.binder, self.objdir, self.kdir, self.jobs)
> self.cleancmd = "%s make O=%s -C %s clean allmodconfig" \
> % (self.binder, self.objdir, self.kdir)
> --
> 2.29.2
>
>
Haven't forgotten this, just need to test before I accept it, on my list
to do.
John
next prev parent reply other threads:[~2021-02-22 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 2:12 [rteval PATCH 0/2] Relax some architecture specific constraints Punit Agrawal
2021-01-26 2:12 ` [rteval PATCH 1/2] rteval: cyclictest.py: Make 'model name' optional Punit Agrawal
2021-02-22 20:16 ` John Kacur
2021-02-24 1:49 ` Punit Agrawal
2021-01-26 2:12 ` [rteval PATCH 2/2] rteval: cyclictest.py: Make build targets architecture independent Punit Agrawal
2021-02-22 20:18 ` John Kacur [this message]
2021-02-22 0:31 ` [rteval PATCH 0/2] Relax some architecture specific constraints Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42e6355c-a8c-8529-43d5-d3cb1fc1bfbd@redhat.com \
--to=jkacur@redhat.com \
--cc=a.darwish@linutronix.de \
--cc=binh1.tranhai@toshiba.co.jp \
--cc=daniel.sangorrin@toshiba.co.jp \
--cc=dwagner@suse.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=punit1.agrawal@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).