From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C49DC433B4 for ; Mon, 12 Apr 2021 17:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 739BB6124C for ; Mon, 12 Apr 2021 17:43:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244202AbhDLRnl (ORCPT ); Mon, 12 Apr 2021 13:43:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:47564 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243735AbhDLRnj (ORCPT ); Mon, 12 Apr 2021 13:43:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7E6A9AF10; Mon, 12 Apr 2021 17:43:19 +0000 (UTC) Subject: Re: [PATCH 01/11] mm/page_alloc: Split per cpu page lists and zone stats To: Mel Gorman , Linux-MM , Linux-RT-Users Cc: LKML , Chuck Lever , Jesper Dangaard Brouer , Matthew Wilcox , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Michal Hocko , Oscar Salvador References: <20210407202423.16022-1-mgorman@techsingularity.net> <20210407202423.16022-2-mgorman@techsingularity.net> From: Vlastimil Babka Message-ID: <81cf880c-826e-6bbf-3af0-22d7aa2d3075@suse.cz> Date: Mon, 12 Apr 2021 19:43:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210407202423.16022-2-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On 4/7/21 10:24 PM, Mel Gorman wrote: > @@ -6691,7 +6697,7 @@ static __meminit void zone_pcp_init(struct zone *zone) > * relies on the ability of the linker to provide the > * offset of a (static) per cpu variable into the per cpu area. > */ > - zone->pageset = &boot_pageset; > + zone->per_cpu_pageset = &boot_pageset; I don't see any &boot_zonestats assignment here in zone_pcp_init() or its caller(s), which seems strange, as zone_pcp_reset() does it. > zone->pageset_high = BOOT_PAGESET_HIGH; > zone->pageset_batch = BOOT_PAGESET_BATCH; > > @@ -8954,17 +8960,19 @@ void zone_pcp_reset(struct zone *zone) > { > unsigned long flags; > int cpu; > - struct per_cpu_pageset *pset; > + struct per_cpu_zonestat *pzstats; > > /* avoid races with drain_pages() */ > local_irq_save(flags); > - if (zone->pageset != &boot_pageset) { > + if (zone->per_cpu_pageset != &boot_pageset) { > for_each_online_cpu(cpu) { > - pset = per_cpu_ptr(zone->pageset, cpu); > - drain_zonestat(zone, pset); > + pzstats = per_cpu_ptr(zone->per_cpu_zonestats, cpu); > + drain_zonestat(zone, pzstats); > } > - free_percpu(zone->pageset); > - zone->pageset = &boot_pageset; > + free_percpu(zone->per_cpu_pageset); > + free_percpu(zone->per_cpu_zonestats); > + zone->per_cpu_pageset = &boot_pageset; > + zone->per_cpu_zonestats = &boot_zonestats; ^ here > } > local_irq_restore(flags); > }