From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B0DCA9EA0 for ; Fri, 18 Oct 2019 11:02:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BD472064B for ; Fri, 18 Oct 2019 11:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571396535; bh=qe1pRTIHuT98+pMIEe0F/cIOP8RWN3V9qc8QEbjpLYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=UsYy5Ktuw2qNI2nIuMm5CyaTUBN17dCk6FCHfzzrza9lhSo+0O2E9MYHwAklnKXxa 7B3Btcid0+CIB+1C0JDLj3HpBvaP3viwTIOtSPZFsLS2KGH/J0/HNqBLjwFxURvzQJ D8c8S3DgHAkTLwRePYvBsR+M/e3tOAXeTo29K+eg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407741AbfJRLCO (ORCPT ); Fri, 18 Oct 2019 07:02:14 -0400 Received: from inca-roads.misterjones.org ([213.251.177.50]:43379 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390315AbfJRLCO (ORCPT ); Fri, 18 Oct 2019 07:02:14 -0400 Received: from [212.111.254.166] (helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iLQ1L-0005Xu-ES; Fri, 18 Oct 2019 13:02:11 +0200 Date: Fri, 18 Oct 2019 12:02:10 +0100 Message-ID: <86imomz58t.wl-maz@kernel.org> From: Marc Zyngier To: Daniel Wagner Cc: UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Woojung Huh , Andrew Lunn , Stefan Wahren , Jisheng Zhang , Sebastian Andrzej Siewior , Thomas Gleixner Subject: Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling In-Reply-To: <20191018082817.111480-1-dwagner@suse.de> References: <20191018082817.111480-1-dwagner@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 212.111.254.166 X-SA-Exim-Rcpt-To: dwagner@suse.de, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, woojung.huh@microchip.com, andrew@lunn.ch, wahrenst@gmx.net, Jisheng.Zhang@synaptics.com, bigeasy@linutronix.de, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Fri, 18 Oct 2019 09:28:17 +0100, Daniel Wagner wrote: > > handle_simple_irq() expect interrupts to be disabled. The USB > framework is using threaded interrupts, which implies that interrupts > are re-enabled as soon as it has run. > > This reverts the changes from cc89c323a30e ("lan78xx: Use irq_domain > for phy interrupt from USB Int. EP"). > > [ 4.886203] 000: irq 79 handler irq_default_primary_handler+0x0/0x8 enabled interrupts > [ 4.886243] 000: WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:152 __handle_irq_event_percpu+0x154/0x168 > [ 4.896294] 000: Modules linked in: > [ 4.896301] 000: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.3.6 #39 > [ 4.896310] 000: Hardware name: Raspberry Pi 3 Model B+ (DT) > [ 4.896315] 000: pstate: 60000005 (nZCv daif -PAN -UAO) > [ 4.896321] 000: pc : __handle_irq_event_percpu+0x154/0x168 > [ 4.896331] 000: lr : __handle_irq_event_percpu+0x154/0x168 > [ 4.896339] 000: sp : ffff000010003cc0 > [ 4.896346] 000: x29: ffff000010003cc0 x28: 0000000000000060 > [ 4.896355] 000: x27: ffff000011021980 x26: ffff00001189c72b > [ 4.896364] 000: x25: ffff000011702bc0 x24: ffff800036d6e400 > [ 4.896373] 000: x23: 000000000000004f x22: ffff000010003d64 > [ 4.896381] 000: x21: 0000000000000000 x20: 0000000000000002 > [ 4.896390] 000: x19: ffff8000371c8480 x18: 0000000000000060 > [ 4.896398] 000: x17: 0000000000000000 x16: 00000000000000eb > [ 4.896406] 000: x15: ffff000011712d18 x14: 7265746e69206465 > [ 4.896414] 000: x13: ffff000010003ba0 x12: ffff000011712df0 > [ 4.896422] 000: x11: 0000000000000001 x10: ffff000011712e08 > [ 4.896430] 000: x9 : 0000000000000001 x8 : 000000000003c920 > [ 4.896437] 000: x7 : ffff0000118cc410 x6 : ffff0000118c7f00 > [ 4.896445] 000: x5 : 000000000003c920 x4 : 0000000000004510 > [ 4.896453] 000: x3 : ffff000011712dc8 x2 : 0000000000000000 > [ 4.896461] 000: x1 : 73a3f67df94c1500 x0 : 0000000000000000 > [ 4.896466] 000: Call trace: > [ 4.896471] 000: __handle_irq_event_percpu+0x154/0x168 > [ 4.896481] 000: handle_irq_event_percpu+0x50/0xb0 > [ 4.896489] 000: handle_irq_event+0x40/0x98 > [ 4.896497] 000: handle_simple_irq+0xa4/0xf0 > [ 4.896505] 000: generic_handle_irq+0x24/0x38 > [ 4.896513] 000: intr_complete+0xb0/0xe0 > [ 4.896525] 000: __usb_hcd_giveback_urb+0x58/0xd8 > [ 4.896533] 000: usb_giveback_urb_bh+0xd0/0x170 > [ 4.896539] 000: tasklet_action_common.isra.0+0x9c/0x128 > [ 4.896549] 000: tasklet_hi_action+0x24/0x30 > [ 4.896556] 000: __do_softirq+0x120/0x23c > [ 4.896564] 000: irq_exit+0xb8/0xd8 > [ 4.896571] 000: __handle_domain_irq+0x64/0xb8 > [ 4.896579] 000: bcm2836_arm_irqchip_handle_irq+0x60/0xc0 > [ 4.896586] 000: el1_irq+0xb8/0x140 > [ 4.896592] 000: arch_cpu_idle+0x10/0x18 > [ 4.896601] 000: do_idle+0x200/0x280 > [ 4.896608] 000: cpu_startup_entry+0x20/0x28 > [ 4.896615] 000: rest_init+0xb4/0xc0 > [ 4.896623] 000: arch_call_rest_init+0xc/0x14 > [ 4.896632] 000: start_kernel+0x454/0x480 > > [dwagner: Updated Jisheng's initial patch] > > Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP") > Cc: Woojung Huh > Cc: Marc Zyngier > Cc: Andrew Lunn > Cc: Stefan Wahren > Cc: Jisheng Zhang > Cc: Sebastian Andrzej Siewior > Cc: Thomas Gleixner > Signed-off-by: Daniel Wagner > --- > Hi, > > With Andrew's "net: usb: lan78xx: Connect PHY before registering MAC" > and this patch I am able to boot and use the RPi3 with -rt. > > There was already a lot of dicussion on this topic but no fixes so > far. So I just suggest to revert the original commit since it is not > clear to me what it fixes: > > https://www.spinics.net/lists/netdev/msg542290.html > https://marc.info/?l=linux-netdev&m=154604180927252&w=2 > https://patchwork.kernel.org/patch/10888797/ > > Without this revert RPi3 is not usable for -rt at this point. Acked-by: Marc Zyngier M. -- Jazz is not dead, it just smells funny.