linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
To: John Kacur <jkacur@redhat.com>
Cc: dwagner@suse.de, "Ahmed S . Darwish" <a.darwish@linutronix.de>,
	linux-rt-users@vger.kernel.org, binh1.tranhai@toshiba.co.jp,
	Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
Subject: Re: [rteval PATCH v2 2/3] rteval: cyclictest.py: Make build targets architecture independent
Date: Thu, 04 Mar 2021 15:53:31 +0900	[thread overview]
Message-ID: <87im67tno4.fsf@kokedama.swc.toshiba.co.jp> (raw)
In-Reply-To: <43eaa8bb-26a-112c-8c13-38fe882dbbb@redhat.com> (John Kacur's message of "Tue, 2 Mar 2021 23:24:11 -0500 (EST)")

John Kacur <jkacur@redhat.com> writes:

> On Wed, 24 Feb 2021, Punit Agrawal wrote:
>
>> Not all kernel archiectures provide the "bzImage" target, e.g., arm64
>> provides "Image" which generates an uncompressed kernel binary.
>> 
>> Instead of going down the path of customizing build targets
>> per-architecture, let's drop them altogether. The default kernel
>> target should build the kernel and modules on all architectures
>> anyways.
>> 
>> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
>> ---
>>  rteval/modules/loads/kcompile.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/rteval/modules/loads/kcompile.py b/rteval/modules/loads/kcompile.py
>> index 326f1ae..e747b9f 100644
>> --- a/rteval/modules/loads/kcompile.py
>> +++ b/rteval/modules/loads/kcompile.py
>> @@ -58,7 +58,7 @@ class KBuildJob:
>>          else:
>>              self.jobs = self.calc_jobs_per_cpu() * len(self.node)
>>          self.log(Log.DEBUG, "node %d: jobs == %d" % (int(node), self.jobs))
>> -        self.runcmd = "%s make O=%s -C %s -j%d bzImage modules" \
>> +        self.runcmd = "%s make O=%s -C %s -j%d" \
>>                  % (self.binder, self.objdir, self.kdir, self.jobs)
>>          self.cleancmd = "%s make O=%s -C %s clean allmodconfig" \
>>                  % (self.binder, self.objdir, self.kdir)
>> -- 
>> 2.30.0
>> 
>> 
>
> Signed-off-by: John Kacur <jkacur@redhat.com>

Hi John,

Thanks for picking up this patch.

Just wanted to make sure about the status of the other 2 patches in the
set - 1/3 and 3/3, I am assuming they're on your TODO but haven't had a
chance to confirm yet.

Let me know if that's not the case for some reason.

Thanks,
Punit

  reply	other threads:[~2021-03-04  6:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  2:16 [rteval PATCH v2 0/3] Make rteval usable on arm, arm64 and i386 Punit Agrawal
2021-02-24  2:16 ` [rteval PATCH v2 1/3] rteval: cyclictest.py: Update logic to get core description Punit Agrawal
2021-02-24  2:16 ` [rteval PATCH v2 2/3] rteval: cyclictest.py: Make build targets architecture independent Punit Agrawal
2021-03-03  4:24   ` John Kacur
2021-03-04  6:53     ` Punit Agrawal [this message]
2021-03-04 15:48       ` John Kacur
2021-03-05  1:33         ` Punit Agrawal
2021-02-24  2:16 ` [rteval PATCH v2 3/3] rteval: systopology.py: Add support for systems that don't have Numa Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im67tno4.fsf@kokedama.swc.toshiba.co.jp \
    --to=punit1.agrawal@toshiba.co.jp \
    --cc=a.darwish@linutronix.de \
    --cc=binh1.tranhai@toshiba.co.jp \
    --cc=daniel.sangorrin@toshiba.co.jp \
    --cc=dwagner@suse.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).