Linux-rt-users Archive on lore.kernel.org
 help / color / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <wagi@monom.org>
Cc: Daniel Wagner <dwagner@suse.de>,
	Clark Williams <williams@redhat.com>,
	linux-rt-users@vger.kernel.org
Subject: Re: [rt-tests v2 01/18] rt-util: Move parse_cpumask from cyclictest
Date: Thu, 29 Oct 2020 11:45:00 -0400 (EDT)
Message-ID: <8cc2d53b-41af-77f9-6e91-38d76d4dad0@redhat.com> (raw)
In-Reply-To: <20201026183425.wxdl3vaoutsrk3bw@beryllium.lan>



On Mon, 26 Oct 2020, Daniel Wagner wrote:

> Hi John,
> 
> On Fri, Oct 23, 2020 at 11:46:54AM -0400, John Kacur wrote:
> > >  TARGETS = $(sources:.c=)
> > >  LIBS	= -lrt -lpthread
> > > -RTTESTLIB = -lrttest -L$(OBJDIR)
> > > +RTTESTLIB = -lrttest -L$(OBJDIR) $(NUMA_LIBS)
> > 
> > Currently only cyclictest was compiled with NUMA_LIBS, this change will 
> > compile everything with NUMA_LIBS. I checked the size of the programs, and 
> > they don't grow that much with this change, but they are small programs to
> > begin with, do we want to keep this functionality separate?
> 
> My thinking is, that the most important program for testing seems to be
> cyclictest. Everyone will run cyclictest on the target platform. Thus
> libnuma will be available. So there wont be any new unresolved
> dependencies.
> 
> I traded the size increase for simplification in the code base and build
> setup. Looking at the actual increase (x86_64, stripped) is not too bad:
> 
> 
> program                 old      new     diff
> ---------------------------------------------------
> cyclicdeadline          35488    35552     64 0.18%
> cyclictest              57632    57632      0 0.0%
> deadline_test           43712    43776     64 0.15%
> hackbench               19168    19168      0 0.0%
> oslat                   36040    36072     32 0.089%
> pip_stress              27296    27360     64 0.23%
> pi_stress               44296    48456   4160 9.4%
> pmqtest                 31864    31928     64 0.2%
> ptsematest              31752    31816     64 0.2%
> queuelat                14600    14600      0 0.0%
> rt-migrate-test         31696    31728     32 0.1%
> signaltest              31712    31776     64 0.2%
> sigwaittest             31792    31856     64 0.2%
> ssdd                    14744    14744      0 0.0%
> svsematest              31856    31920     64 0.2%
> 
> 
> pi_stress is a bit odd though. Not sure what's happening there. Will
> look into it.
> 
> So I would prefer to go this route and makes things simpler in the code
> base.
> 
> Thanks,
> Daniel
> 

You're really just simplifying the Makefile, not the code. :)
Well, that and I guess this means I'm asking you to separate any common
numa functionality into a separate lib. If you want you can just pull out
parse_time_string(), and parse_mem_string() for now until we hash out
what we want to do with the numa functionality later.

Does that work for you?

John 

  reply index

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  8:56 [rt-tests v2 00/18] Streamline command line Daniel Wagner
2020-10-07  8:56 ` [rt-tests v2 01/18] rt-util: Move parse_cpumask from cyclictest Daniel Wagner
2020-10-23 15:46   ` John Kacur
2020-10-26 18:34     ` Daniel Wagner
2020-10-29 15:45       ` John Kacur [this message]
2020-10-07  8:56 ` [rt-tests v2 02/18] cyclictest: Use numa library helpers in get_available_cpus() Daniel Wagner
2020-10-23 15:55   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 03/18] cyclicdeadline: Streamline usage output and man page Daniel Wagner
2020-10-23 16:01   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 04/18] cyclicdeadline: Add long command line options Daniel Wagner
2020-10-23 16:07   ` John Kacur
2020-10-27  8:07     ` Daniel Wagner
2020-10-07  8:56 ` [rt-tests v2 05/18] deadline_test: Streamline usage output and man page Daniel Wagner
2020-10-23 16:10   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 06/18] oslat: " Daniel Wagner
2020-10-23 17:19   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 07/18] oslat: Use string parser utilies Daniel Wagner
2020-10-23 17:25   ` John Kacur
2020-10-27  8:09     ` Daniel Wagner
2020-10-07  8:56 ` [rt-tests v2 08/18] pip_stress: Add command line parser Daniel Wagner
2020-10-23 17:33   ` John Kacur
2020-10-27  8:09     ` Daniel Wagner
2020-10-07  8:56 ` [rt-tests v2 09/18] pi_stress: Streamline usage output and man page Daniel Wagner
2020-10-07  8:56 ` [rt-tests v2 10/18] pmqtest: " Daniel Wagner
2020-10-23 18:18   ` John Kacur
2020-10-23 18:23   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 11/18] ptsematest: " Daniel Wagner
2020-10-23 18:25   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 12/18] queuelat: Streamline usage " Daniel Wagner
2020-10-23 18:40   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 13/18] rt-migrate-test: " Daniel Wagner
2020-10-23 18:47   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 14/18] signaltest: " Daniel Wagner
2020-10-23 18:50   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 15/18] sigwaittest: " Daniel Wagner
2020-10-23 18:51   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 16/18] ssdd: " Daniel Wagner
2020-10-23 18:57   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 17/18] svsematest: " Daniel Wagner
2020-10-23 18:59   ` John Kacur
2020-10-07  8:56 ` [rt-tests v2 18/18] hackbench: " Daniel Wagner
2020-10-23 19:03   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cc2d53b-41af-77f9-6e91-38d76d4dad0@redhat.com \
    --to=jkacur@redhat.com \
    --cc=dwagner@suse.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=wagi@monom.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-rt-users Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git