From: Ramon Fried <rfried.dev@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Tom Zanussi <zanussi@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Daniel Wagner <wagi@monom.org>,
Clark Williams <williams@redhat.com>,
Zhang Xiao <xiao.zhang@windriver.com>
Subject: Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue
Date: Tue, 09 Jun 2020 19:37:31 +0300 [thread overview]
Message-ID: <D6892A4E-18F7-4EB7-BA09-BD4DF9079BDE@gmail.com> (raw)
In-Reply-To: <20200609163446.efp76qbjzkbtl7nk@linutronix.de>
On June 9, 2020 7:34:46 PM GMT+03:00, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>On 2020-06-09 11:17:53 [-0500], Tom Zanussi wrote:
>> Hi Sebastian,
>Hi Tom,
>
>> I did find a problem with the patch when configured as !SMP since in
>> that case the RUN flag is never set (will send a patch for that
>> shortly), but that wouldn't be the case here.
>
>How?
>
>| #if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT_FULL)
>| static inline int tasklet_trylock(struct tasklet_struct *t)
>| {
>| return !test_and_set_bit(TASKLET_STATE_RUN, &(t)->state);
>| }
>
>I can't tell from the backtrace if he runs with RT or without but I
>assumed RT. But yes, for !SMP && !RT it would explain it.
PREEMT_FULL is enabled.
I'm working on getting symbols for this trace, this is a crash kernel so everything is stripped naked.
Thanks, Ramon
>
>> It would help to be able to reproduce it, but I haven't been able to
>> yet.
>>
>> Tom
>>
>Sebastian
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2020-06-09 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 20:54 [PATCH RT 0/2] Linux v4.19.115-rt49-rc1 zanussi
2020-04-23 20:54 ` [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue zanussi
2020-06-04 16:04 ` Ramon Fried
2020-06-04 20:51 ` Tom Zanussi
2020-06-09 15:47 ` Sebastian Andrzej Siewior
2020-06-09 16:17 ` Tom Zanussi
2020-06-09 16:34 ` Sebastian Andrzej Siewior
2020-06-09 16:37 ` Ramon Fried [this message]
2020-06-09 16:40 ` Ramon Fried
2020-06-09 16:42 ` Sebastian Andrzej Siewior
2020-06-09 17:07 ` Ramon Fried
2020-06-09 17:10 ` Sebastian Andrzej Siewior
2020-06-09 17:14 ` Ramon Fried
2020-06-09 17:20 ` Tom Zanussi
2020-06-09 20:03 ` Ramon Fried
2020-06-09 20:09 ` Tom Zanussi
2020-06-09 16:57 ` Tom Zanussi
2020-04-23 20:54 ` [PATCH RT 2/2] Linux 4.19.115-rt49-rc1 zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6892A4E-18F7-4EB7-BA09-BD4DF9079BDE@gmail.com \
--to=rfried.dev@gmail.com \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
--cc=williams@redhat.com \
--cc=xiao.zhang@windriver.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).