From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F13C76195 for ; Wed, 17 Jul 2019 09:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB38620880 for ; Wed, 17 Jul 2019 09:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbfGQJC2 (ORCPT ); Wed, 17 Jul 2019 05:02:28 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:52676 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbfGQJC1 (ORCPT ); Wed, 17 Jul 2019 05:02:27 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hnfpQ-0001Xv-Vz; Wed, 17 Jul 2019 11:02:25 +0200 Date: Wed, 17 Jul 2019 11:02:23 +0200 (CEST) From: Thomas Gleixner To: Paul Thomas cc: linux-rt-users , dunc.mcphie@gmail.com, Anders Roxell Subject: Re: poor cyclictest results with 5.0 series rt for arm64 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-rt-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Wed, 17 Jul 2019, Thomas Gleixner wrote: > On Wed, 17 Jul 2019, Thomas Gleixner wrote: > > > Paul, > > > > On Tue, 16 Jul 2019, Paul Thomas wrote: > > > On Tue, Jul 16, 2019 at 7:14 PM Thomas Gleixner wrote: > > > > Either that patch is broken or it got broken on forward porting it from > > > > 4.19. Need to look with brain awake tomorrow. > > > > > > Yes! this looks like it fixes it. The hash I see is slightly different: > > > b7f42e8fb48cbe38e4c2d0cab48309aadfa6d032 > > > > > > But the name was the same "arch/arm64: Add lazy preempt support" > > > > So, brain works better now. Can you test the patch below? > > Bah, ignore that. Still broken. -ENOTENOUGHCOFFEE The one below should fix it for real. Thanks, tglx 8<-------------------- --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -612,10 +612,12 @@ ENDPROC(el1_sync) ldr x24, [tsk, #TSK_TI_PREEMPT] // get preempt count cbnz x24, 2f // preempt count != 0 + ldr x0, [tsk, #TSK_TI_FLAGS] // get flags + tbnz x0, #TIF_NEED_RESCHED, 1f // needs rescheduling? + ldr w24, [tsk, #TSK_TI_PREEMPT_LAZY] // get preempt lazy count cbnz w24, 2f // preempt lazy count != 0 - ldr x0, [tsk, #TSK_TI_FLAGS] // get flags tbz x0, #TIF_NEED_RESCHED_LAZY, 2f // needs rescheduling? 1: bl el1_preempt