Re: [PATCH 2/4] rt-tests: cyclictest: Make tracemark work correctly again

[John Kacur <jkacur@redhat.com>]

On Tue, 17 Sep 2019, Kurt Kanzenbach wrote:

> Hi John,
> 
> On Mon, Sep 16, 2019 at 11:51:09PM +0200, John Kacur wrote:
> > commit f5ccfbe4d6641e48f56152be135d901dd31cba7e
> > was a little too aggressive removing ftrace code.
> >
> > We were able to remove ftrace code because this functionality is
> > available using trace-cmd, in conjunction with the tracemark option in
> > cyclictest. Put back the parts of tracemark needed to make this work
> > correctly.
> >
> > After this patch you can get tracing info like this as an example.
> >
> > trace-cmd record -p function ./cyclictest -t -b100 --tracemark
> >
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> >  src/cyclictest/cyclictest.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> > index 52f93da7d074..45b6041ec1c9 100644
> > --- a/src/cyclictest/cyclictest.c
> > +++ b/src/cyclictest/cyclictest.c
> > @@ -184,6 +184,7 @@ static void trigger_update(struct thread_param *par, int diff, int64_t ts);
> >
> >  static int shutdown;
> >  static int tracelimit = 0;
> > +static int trace_marker = 9;
> 
> Shouldn't this be 'static int trace_marker = 0'? Otherwise it's always set.
> 
> Thanks,
> Kurt
> 

I left my computer glasses in Germany - no seriously I did!
Thanks for spotting that, respinning the patch

John