Linux-rt-users archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open()
@ 2020-06-20  2:44 Yunfeng Ye
  2020-07-01 15:38 ` John Kacur
  0 siblings, 1 reply; 3+ messages in thread
From: Yunfeng Ye @ 2020-06-20  2:44 UTC (permalink / raw)
  To: williams, jkacur, linux-rt-users, Shiyuan Hu, Hewenliang

The infomation "pid = xxx" is printed with other infomation on the same
line. so add '\n' symbol for printf in rstat_shm_open().

Signed-off-by: yeyunfeng <yeyunfeng@huawei.com>
---
 src/cyclictest/cyclictest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index b3d72caa10ce..d1c148563dad 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -1910,7 +1910,7 @@ static int rstat_shm_open(void)
 	pid_t pid;

 	pid = getpid();
-	printf("pid = %d", pid);
+	printf("pid = %d\n", pid);

 	snprintf(shm_name, SHM_BUF_SIZE, "%s%d", "/cyclictest", pid);

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open()
  2020-06-20  2:44 [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open() Yunfeng Ye
@ 2020-07-01 15:38 ` John Kacur
  2020-07-02  1:25   ` Yunfeng Ye
  0 siblings, 1 reply; 3+ messages in thread
From: John Kacur @ 2020-07-01 15:38 UTC (permalink / raw)
  To: Yunfeng Ye; +Cc: williams, linux-rt-users, Shiyuan Hu, Hewenliang



On Sat, 20 Jun 2020, Yunfeng Ye wrote:

> The infomation "pid = xxx" is printed with other infomation on the same
> line. so add '\n' symbol for printf in rstat_shm_open().
> 
> Signed-off-by: yeyunfeng <yeyunfeng@huawei.com>
> ---
>  src/cyclictest/cyclictest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index b3d72caa10ce..d1c148563dad 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -1910,7 +1910,7 @@ static int rstat_shm_open(void)
>  	pid_t pid;
> 
>  	pid = getpid();
> -	printf("pid = %d", pid);
> +	printf("pid = %d\n", pid);
> 
>  	snprintf(shm_name, SHM_BUF_SIZE, "%s%d", "/cyclictest", pid);
> 
> -- 
> 1.8.3.1
> 
> 
oops, that looks like my debug code that I forgot to remove. Do you want 
to send a patch removing that line?

Thanks

John Kacur

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open()
  2020-07-01 15:38 ` John Kacur
@ 2020-07-02  1:25   ` Yunfeng Ye
  0 siblings, 0 replies; 3+ messages in thread
From: Yunfeng Ye @ 2020-07-02  1:25 UTC (permalink / raw)
  To: John Kacur; +Cc: williams, linux-rt-users, Shiyuan Hu, Hewenliang



On 2020/7/1 23:38, John Kacur wrote:
> 
> 
> On Sat, 20 Jun 2020, Yunfeng Ye wrote:
> 
>> The infomation "pid = xxx" is printed with other infomation on the same
>> line. so add '\n' symbol for printf in rstat_shm_open().
>>
>> Signed-off-by: yeyunfeng <yeyunfeng@huawei.com>
>> ---
>>  src/cyclictest/cyclictest.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index b3d72caa10ce..d1c148563dad 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -1910,7 +1910,7 @@ static int rstat_shm_open(void)
>>  	pid_t pid;
>>
>>  	pid = getpid();
>> -	printf("pid = %d", pid);
>> +	printf("pid = %d\n", pid);
>>
>>  	snprintf(shm_name, SHM_BUF_SIZE, "%s%d", "/cyclictest", pid);
>>
>> -- 
>> 1.8.3.1
>>
>>
> oops, that looks like my debug code that I forgot to remove. Do you want 
> to send a patch removing that line?
> 
ok, I will send a patch v2, thanks.

> Thanks
> 
> John Kacur
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-20  2:44 [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open() Yunfeng Ye
2020-07-01 15:38 ` John Kacur
2020-07-02  1:25   ` Yunfeng Ye

Linux-rt-users archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git