Linux-rt-users Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] rt-tests: oslat: Allow build for not supported archs
@ 2020-10-01 18:47 Peter Xu
  2020-10-23 14:52 ` John Kacur
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Xu @ 2020-10-01 18:47 UTC (permalink / raw)
  To: linux-rt-users; +Cc: Clark Williams, Randy Witt, John Kacur, peterx

Now rt-tests won't build for archs other than x86/i386/ppc64 after oslat is
merged.  Instead of failing the build, let's make it pass.  However, whenever
oslat is executed, instead of running the real program, dump an error message,
so that people can try to implement the frc() function for it when there's a
real need for the new arch.

Signed-off-by: Peter Xu <peterx@redhat.com>
---

Just in case this got lost - I'm posting as a formal patch.  Please feel free
to comment here directly.
---
 src/oslat/oslat.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
index f1a82f2..a8b6155 100644
--- a/src/oslat/oslat.c
+++ b/src/oslat/oslat.c
@@ -69,7 +69,9 @@ static inline void frc(uint64_t *pval)
 	__asm__ __volatile__("mfspr %0, 268\n" : "=r" (*pval));
 }
 # else
-#  error Need frc() for this platform.
+#  define relax()          do { } while (0)
+#  define frc(x)
+#  define FRC_MISSING
 # endif
 #else
 # error Need to add support for this compiler.
@@ -810,6 +812,12 @@ int main(int argc, char *argv[])
 	int i, n_cores;
 	cpu_set_t cpu_set;
 
+#ifdef FRC_MISSING
+	printf("This architecture is not yet supported. "
+	       "Please implement frc() function first for %s.\n", argv[0]);
+	return 0;
+#endif
+
 	CPU_ZERO(&cpu_set);
 
 	g.app_name = argv[0];
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] rt-tests: oslat: Allow build for not supported archs
  2020-10-01 18:47 [PATCH] rt-tests: oslat: Allow build for not supported archs Peter Xu
@ 2020-10-23 14:52 ` John Kacur
  0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2020-10-23 14:52 UTC (permalink / raw)
  To: Peter Xu; +Cc: linux-rt-users, Clark Williams, Randy Witt



On Thu, 1 Oct 2020, Peter Xu wrote:

> Now rt-tests won't build for archs other than x86/i386/ppc64 after oslat is
> merged.  Instead of failing the build, let's make it pass.  However, whenever
> oslat is executed, instead of running the real program, dump an error message,
> so that people can try to implement the frc() function for it when there's a
> real need for the new arch.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> 
> Just in case this got lost - I'm posting as a formal patch.  Please feel free
> to comment here directly.
> ---
>  src/oslat/oslat.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index f1a82f2..a8b6155 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -69,7 +69,9 @@ static inline void frc(uint64_t *pval)
>  	__asm__ __volatile__("mfspr %0, 268\n" : "=r" (*pval));
>  }
>  # else
> -#  error Need frc() for this platform.
> +#  define relax()          do { } while (0)
> +#  define frc(x)
> +#  define FRC_MISSING
>  # endif
>  #else
>  # error Need to add support for this compiler.
> @@ -810,6 +812,12 @@ int main(int argc, char *argv[])
>  	int i, n_cores;
>  	cpu_set_t cpu_set;
>  
> +#ifdef FRC_MISSING
> +	printf("This architecture is not yet supported. "
> +	       "Please implement frc() function first for %s.\n", argv[0]);
> +	return 0;
> +#endif
> +
>  	CPU_ZERO(&cpu_set);
>  
>  	g.app_name = argv[0];
> -- 
> 2.26.2
> 
> 
Signed-off-by: John Kacur <jkacur@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 18:47 [PATCH] rt-tests: oslat: Allow build for not supported archs Peter Xu
2020-10-23 14:52 ` John Kacur

Linux-rt-users Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
		linux-rt-users@vger.kernel.org
	public-inbox-index linux-rt-users

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git