From: Waiman Long <longman@redhat.com>
To: Scott Wood <swood@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Juri Lelli <jlelli@redhat.com>
Subject: Re: [PATCH RT] kernel/sched: Don't recompute cpumask weight in migrate_enable_update_cpus_allowed()
Date: Fri, 18 Oct 2019 14:18:43 -0400
Message-ID: <fc777b62-63e2-8391-ce02-3fa7b88db27a@redhat.com> (raw)
In-Reply-To: <0979a9a345e47be69783a2183dd31911e9fc755e.camel@redhat.com>
On 10/12/19 3:06 AM, Scott Wood wrote:
> On Fri, 2019-10-11 at 10:09 -0400, Waiman Long wrote:
>> At each invocation of rt_spin_unlock(), cpumask_weight() is called
>> via migrate_enable_update_cpus_allowed() to recompute the weight of
>> cpus_mask which doesn't change that often.
>>
>> The following is a sample output of perf-record running the testpmd
>> microbenchmark on an RT kernel:
>>
>> 34.77% 1.65% testpmd [kernel.kallsyms] [k] rt_spin_unlock
>> 34.32% 2.52% testpmd [kernel.kallsyms] [k] migrate_enable
>> 21.76% 21.76% testpmd [kernel.kallsyms] [k] __bitmap_weight
>>
>> By adding an extra variable to keep track of the weight of cpus_mask,
>> we could eliminate the frequent call to cpumask_weight() and replace
>> it with simple assignment.
> Can you try this with my migrate disable patchset (which makes
> amigrate_enable_update_cpus_allowed() be called much less often) and see if
> caching nr_cpus_allowed still makes a difference?
>
> -Scott
With lazy migrate_disable, I do think my patch will no longer be necessary.
Thanks,
Longman
prev parent reply index
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:09 Waiman Long
2019-10-12 7:06 ` Scott Wood
2019-10-18 18:18 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc777b62-63e2-8391-ce02-3fa7b88db27a@redhat.com \
--to=longman@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=jlelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-rt-users Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-rt-users/0 linux-rt-users/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-rt-users linux-rt-users/ https://lore.kernel.org/linux-rt-users \
linux-rt-users@vger.kernel.org
public-inbox-index linux-rt-users
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rt-users
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git